Fix background header colors and set defaults#11
Open
ahalekelly wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks, I'll take a look! |
Author
|
Thanks! I slightly prefer the background-secondary color as it gives the header row a bit of contrast from the other rows But you could also make background-primary the default color to keep the standard Obsidian look 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the header background would sometimes be transparent even when a color was set.
Also sets the default header background color to the color of the sidebar background, --background-secondary. If that color changes, the header background will update. The user can override the color with Style Settings, and have separate color values for light and dark mode.