Cache _get_directory lookups during collection#4
Open
adamtheturtle wants to merge 1 commit into
Open
Conversation
_get_directory is called frequently via conftest resolution; caching avoids repeated Path.is_file() stats on the hot path. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 07982a9. Configure here.
|
|
||
| Cached because this is called frequently during collection (via | ||
| ``gethookproxy`` / ``_getconftestmodules``) and ``Path.is_file()`` stats. | ||
| """ |
There was a problem hiding this comment.
Stale directory cache across sessions
Medium Severity
Module-level @lru_cache on _get_directory keeps Path.is_file() results for the whole interpreter, while each pytest run creates a new PytestPluginManager whose own smaller cache is empty. A later in-process run can reuse a stale directory for the same path if the filesystem changed, breaking conftest resolution.
Reviewed by Cursor Bugbot for commit 07982a9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
_get_directory()(used by conftest / hook-proxy path resolution) to avoid repeatedPath.is_file()stats.Timing (pytest's own
testing/suite)Warm interleaved A/B
pytest testing/ --collect-only -q(12 pairs, alternate order).mainCollected 4286 tests each run.
Note: this suite is only ~4k tests / ~0.5–1.5s collect, so single micro-optimizations are often within run-to-run noise. Larger synthetic suites show clearer wins.
Test plan
testing/test_conftest.py