Defer TopRequest creation until first access#12
Open
adamtheturtle wants to merge 1 commit into
Open
Conversation
Collect-only paths that never touch the fixture request skip constructing TopRequest. Reading item._request after collection still works via lazy init; teardown clearing does not immediately recreate it. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TopRequestuntilitem._requestis first read (or setup/run).item._requestaccess working via lazy init; teardown clearing does not recreate it.Timing (pytest's own
testing/suite)Warm interleaved A/B
pytest testing/ --collect-only -q(8 pairs).mainCollected 4286 tests each run.
Note: this suite is only ~4k tests / ~0.5–1.5s collect, so single micro-optimizations are often within run-to-run noise.
Test plan
testing/test_runner.py::...::test_keyboardinterrupt_clears_request_and_funcargstesting/python/fixtures.py::TestRequestBasicMade with Cursor