Repository navigation
Optimize SDK finalization and dependency reuse - #17
Merged
Merged
Conversation
Mira PR WalkthroughThis PR optimizes .NET SDK derivation finalization and dependency reuse while preserving the existing SDK/workload installation flow. It adds SDK-version parsing so finalized SDKs can reuse matching nixpkgs reference and runtime packs, replaces the heavier setup-hook dependency with a focused substituted hook, and keeps Linux and Darwin finalization behavior separate. The public documentation/examples are updated to consistently follow the consuming flake’s nixpkgs input, with unit coverage added for SDK version parsing and the existing finalization helpers. graph LR
lib["src/lib.nix"] --> sdk["src/nix-dotnet.nix"]
sdk --> tests["tests/unit.nix"]
sdk --> readme["README.md"]
sdk --> basic["examples/basic/flake.nix"]
sdk --> multi["examples/multi-sdk/flake.nix"]
Confidence: 4/5 ◉◉◉◉○ Safe with minor fixes
7 files reviewed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.