Skip to content

Optimize SDK finalization and dependency reuse - #17

Merged
adampoit merged 1 commit into
mainfrom
build-speed
Sep 4, 2026
Merged

adampoit merged 1 commit into
mainfrom
build-speed

Conversation

@adampoit

@adampoit adampoit commented Sep 4, 2026

Copy link
Copy Markdown
Owner

No description provided.

@not-adam

not-adam Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Mira PR Walkthrough

This PR optimizes .NET SDK derivation finalization and dependency reuse while preserving the existing SDK/workload installation flow. It adds SDK-version parsing so finalized SDKs can reuse matching nixpkgs reference and runtime packs, replaces the heavier setup-hook dependency with a focused substituted hook, and keeps Linux and Darwin finalization behavior separate. The public documentation/examples are updated to consistently follow the consuming flake’s nixpkgs input, with unit coverage added for SDK version parsing and the existing finalization helpers.

graph LR
lib["src/lib.nix"] --> sdk["src/nix-dotnet.nix"]
sdk --> tests["tests/unit.nix"]
sdk --> readme["README.md"]
sdk --> basic["examples/basic/flake.nix"]
sdk --> multi["examples/multi-sdk/flake.nix"]
Loading
Confidence: 4/5   ◉◉◉◉○   Safe with minor fixes
  • The changes are localized, include unit-test coverage for the new helper and existing command-generation behavior, and maintain the established API; confidence is slightly reduced because derivation behavior and cross-platform dependency reuse are not executable from the provided review context.

7 files reviewed


Comment @not-adam help to get the list of available commands and usage tips.

@adampoit
adampoit merged commit 832b084 into main Sep 4, 2026
11 checks passed
@adampoit
adampoit deleted the build-speed branch September 4, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant