Resolve Class references by name when not caching subscribers#33
Open
Nevett wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Rails app using entity_store runs in development with code reloading enabled, modifying a subscriber class causes subsequent event dispatch to raise:
▎ A copy of FooService has been removed from the module tree but is still active!
The cause:
EntityStore::Config.event_subscribersholds bare Class references captured at boot. After Rails unloads and reloads a class, the constant points at a fresh Class object but the registry still holds the old, dead one.EventBus#send_to_subscriberthen calls.newon the dead class.EventBus#subscribersalready supports lazy resolution of String entries via EntityStore::Config.load_type. This change extends the same treatment to Class entries, gated on the existing cache_event_subscribers flag.cache_event_subscribers = true(production default): Class entries are returned unchanged. Behavior unchanged.cache_event_subscribers = false(typical dev/test): Class entries are re-resolved viaload_type(klass.name)so the current constant binding is used.