add float support to settings.toml and supervisor.get_setting()#10975
Merged
dhalbert merged 4 commits intoadafruit:mainfrom May 4, 2026
Merged
add float support to settings.toml and supervisor.get_setting()#10975dhalbert merged 4 commits intoadafruit:mainfrom
dhalbert merged 4 commits intoadafruit:mainfrom
Conversation
tannewt
approved these changes
May 4, 2026
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
This looks fine to me.
Would you mind adding Zephyr native_sim tests? It should be able to test this.
Collaborator
Author
I will add this in another PR, but definitely will do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add float support for settings.toml, so we can add several new controls for startup values, such as safe-mode delay, BLE startup delay, etc.
This code was developed with careful guiding of Claude Code using the Sonnet 4.6 model. Because this code must be allocation-free, there is some extra code for doing signed numbers beyond calling the basic float number parser.
Because
ports/unixdoes not implementsupervisor, a manual test was developed. I ran it and tested it. The original generated test usedmath.infandmath.nan, which are not available (#10974), and I worked around that.Also I clarified some comments having to do with
SETTINGS_ERR_*.I fixed a couple of build problems which were unrelated to primary point of the PR.