Skip to content

Fix conversation runtime regressions - #239

Merged
actus7 merged 1 commit into
mainfrom
agent/fix-conversation-runtime-regression
Aug 19, 2026
Merged

Fix conversation runtime regressions#239
actus7 merged 1 commit into
mainfrom
agent/fix-conversation-runtime-regression

Conversation

@actus7

@actus7 actus7 commented Aug 19, 2026

Copy link
Copy Markdown
Owner

What changed

  • normalize conversation titles at the API boundary so stale clients cannot fail long prompts with Invalid conversation payload
  • keep Harness runs active until every explicitly requested iterative section is present, while accepting qualified headings such as Entrega Final
  • avoid retrying DuckAI when the configured local Chrome runtime is deterministically unavailable
  • load the persisted accent through an external beforeInteractive script to remove React/Next development console errors
  • add regression coverage for long titles, iterative completion, and DuckAI fallback behavior

Root cause

The local client used the full first prompt as a conversation title while the conversations API rejected titles over 200 characters. In addition, the Harness trusted a provider stop finish reason even when the requested multi-round format was incomplete, and an exact heading comparison could keep a completed run alive when the model wrote Entrega Final.

Impact

Long prompts now create conversations successfully even from stale bundles. Explicit multi-round prompts continue until their requested sections are delivered, deterministic provider failures fall through faster in Auto mode, and the chat loads without the accent hydration/console regression.

Validation

  • exact reported prompt exercised in authenticated ModelHub Auto + Harness mode on localhost
  • conversation creation returned 201 and Harness continuation calls returned 200
  • all three rounds and the final FapiBird artifact were rendered without Invalid conversation payload
  • pnpm test — 467 passed, 1 skipped
  • pnpm typecheck — passed
  • pnpm lint — 0 errors (1 unrelated pre-existing warning under .remember/tmp)
  • pnpm build — passed

Copilot AI lite review requested due to automatic review settings August 19, 2026 20:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modelhub Ready Ready Preview Aug 19, 2026 8:17pm

@github-actions github-actions Bot added frontend Frontend changes backend Backend changes tests Test changes labels Aug 19, 2026
@actus7
actus7 merged commit 63f4f58 into main Aug 19, 2026
12 checks passed
@actus7
actus7 deleted the agent/fix-conversation-runtime-regression branch August 19, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend changes frontend Frontend changes tests Test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants