Fix conversation runtime regressions - #239
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Invalid conversation payloadEntrega FinalbeforeInteractivescript to remove React/Next development console errorsRoot cause
The local client used the full first prompt as a conversation title while the conversations API rejected titles over 200 characters. In addition, the Harness trusted a provider
stopfinish reason even when the requested multi-round format was incomplete, and an exact heading comparison could keep a completed run alive when the model wroteEntrega Final.Impact
Long prompts now create conversations successfully even from stale bundles. Explicit multi-round prompts continue until their requested sections are delivered, deterministic provider failures fall through faster in Auto mode, and the chat loads without the accent hydration/console regression.
Validation
Invalid conversation payloadpnpm test— 467 passed, 1 skippedpnpm typecheck— passedpnpm lint— 0 errors (1 unrelated pre-existing warning under.remember/tmp)pnpm build— passed