Fix actix-http examples#1259
Merged
Merged
Conversation
JohnTitor
requested changes
Jan 6, 2020
Member
JohnTitor
left a comment
There was a problem hiding this comment.
I prefer to use .await over returning Ok(()), as other examples do so.
Did anyone ever run them?!
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
- Coverage 80.45% 79.06% -1.39%
==========================================
Files 159 159
Lines 18518 18518
==========================================
- Hits 14899 14642 -257
- Misses 3619 3876 +257
Continue to review full report at Codecov.
|
JohnTitor
approved these changes
Jan 6, 2020
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did anyone ever run them?!
This was preventing #1258 from passing.