Skip to content

Fix actix-http examples#1259

Merged
JohnTitor merged 1 commit into
actix:masterfrom
linkmauve:fix-tests
Jan 6, 2020
Merged

Fix actix-http examples#1259
JohnTitor merged 1 commit into
actix:masterfrom
linkmauve:fix-tests

Conversation

@linkmauve
Copy link
Copy Markdown
Contributor

Did anyone ever run them?!

This was preventing #1258 from passing.

Copy link
Copy Markdown
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use .await over returning Ok(()), as other examples do so.

Comment thread actix-http/examples/echo.rs Outdated
Comment thread actix-http/examples/echo2.rs Outdated
Comment thread actix-http/examples/hello-world.rs Outdated
Did anyone ever run them?!
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2020

Codecov Report

Merging #1259 into master will decrease coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   80.45%   79.06%   -1.39%     
==========================================
  Files         159      159              
  Lines       18518    18518              
==========================================
- Hits        14899    14642     -257     
- Misses       3619     3876     +257
Impacted Files Coverage Δ
tests/test_server.rs 50.65% <0%> (-46.48%) ⬇️
actix-http/src/encoding/decoder.rs 59.82% <0%> (-12.51%) ⬇️
src/test.rs 75.94% <0%> (-8.02%) ⬇️
src/web.rs 84.61% <0%> (-7.7%) ⬇️
awc/src/sender.rs 53.91% <0%> (-6.09%) ⬇️
awc/src/request.rs 75.73% <0%> (-3.31%) ⬇️
actix-http/src/encoding/encoder.rs 69.17% <0%> (-3.01%) ⬇️
actix-http/src/client/h2proto.rs 72.28% <0%> (-2.41%) ⬇️
actix-http/src/response.rs 83.7% <0%> (-0.89%) ⬇️
actix-http/src/h1/encoder.rs 83.58% <0%> (-0.6%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2803fcb...4103be0. Read the comment docs.

@JohnTitor JohnTitor merged commit f5fd6bc into actix:master Jan 6, 2020
@JohnTitor
Copy link
Copy Markdown
Member

Thanks!

@linkmauve linkmauve deleted the fix-tests branch January 6, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants