Fix OpenAI Chat stream: prevent tool_calls[].type becoming "functionf… #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Fixes an OpenAI Chat streaming merge issue where tool_calls[].type could become "functionfunctionfunction..." due to string concatenation during delta merges.
Changes:
- Convert streaming deltas via
api_message.delta.deep_to_hto preserve non-string enum values (preventinghash_merge_deltastring concatenation on:type). - Normalize tool call type handling by switching
process_function_callsto compareapi_function_call[:type].to_sagainst"function".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plusor
force-pushed
the
main
branch
2 times, most recently
from
674a691 to
3df2617
Compare
…unction..." When merging streaming deltas, delta was converted with as_json.deep_symbolize_keys, which left tool_calls[].type as the string "function". hash_merge_delta concatenates when the existing value is a String (hash[key] += value), so each chunk appended "function" and produced "functionfunctionfunction...". - Use delta.deep_to_h so the gem returns symbol-keyed hashes with :type => :function. Merges then hit the replace branch and type stays :function. - Match when :function in process_function_calls for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unction..."
When merging streaming deltas, delta was converted with as_json.deep_symbolize_keys, which left tool_calls[].type as the string "function". hash_merge_delta concatenates when the existing value is a String (hash[key] += value), so each chunk appended "function" and produced "functionfunctionfunction...".