Repository navigation
Fix Copier conflict detection for whitespace and new files - #24
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 84.69% 85.46% +0.76%
==========================================
Files 8 8
Lines 477 509 +32
Branches 41 46 +5
==========================================
+ Hits 404 435 +31
- Misses 58 59 +1
Partials 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copier updates such as tkp-aliases/nbprint-logfire#33 received conflict warnings because
git diff --checkalso reports whitespace errors. That PR added four Makefile lines with trailing spaces and contained no conflict markers.Disable whitespace diagnostics for the conflict check and inspect staged changes after lockfile refresh, so newly added files are checked too. Warn about unresolved conflict markers explicitly, and propagate other Git failures.
make lint checks coveragepasses: 26 tests. Real Git regression cases reproduce the previous whitespace false positives and missed conflicts in new files, then pass with this fix.