fix: prevent ENS lookup on non-EVM addresses #2190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip ENS resolution for Solana and other non-EVM addresses by checking isValidAddress() before enabling the query. This prevents ethers.js getAddress() from throwing on invalid address formats. Fixes ACROSS-FRONTEND-Y8T
0xjorgen
requested review from
amateima,
dohaki,
gsteenkamp89,
mrice32 and
nicholaspai
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Deployment failed with the following error: Learn More: https://vercel.link/3Fpeeb1 |
src/hooks/useEns.ts
Outdated
| import { useQuery } from "@tanstack/react-query"; | ||
|
|
||
| import { ChainId, getProvider, isDefined } from "utils"; | ||
| import { ChainId, getProvider, isDefined, isValidAddress } from "utils"; |
Contributor
There was a problem hiding this comment.
slightly unrelated, but should we maybe rename isValidAddress to isEvmAddress in our utils dir?
In api/_addresses.ts we export these utilities from ethers and solana/kit this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip ENS resolution for Solana and other non-EVM addresses by checking
isValidAddress() before enabling the query. This prevents ethers.js
getAddress() from throwing on invalid address formats.
Fixes ACROSS-FRONTEND-Y8T