fix: add null check for sender/recipient in transfer event properties #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents crash when sender or recipient is undefined by using optional chaining in the isSenderEqRecipient comparison. Fixes FE-277
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xjorgen
requested review from
amateima,
dohaki,
gsteenkamp89 and
nicholaspai
as code owners
|
Deployment failed with the following error: Learn More: https://vercel.link/3Fpeeb1 |
gsteenkamp89
requested changes
Jan 21, 2026
Comment on lines
6
to
7
| sender: string; | ||
| recipient: string; |
Contributor
There was a problem hiding this comment.
Let's change our type definitions to reflect reality
Suggested change
| sender: string | undefined | null; | |
| recipient: string | undefined | null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents crash when sender or recipient is undefined by using optional
chaining in the isSenderEqRecipient comparison.
Fixes FE-277