Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the Acquia ID SSO route so authenticated users with an existing token are allowed through route access and receive an “already logged in” experience instead of a 403.
Changes:
- Injects the current user into
OAuth2Controller. - Adds an authenticated-with-token branch that returns a render array with a Continue link.
- Updates the kernel access test to expect the SSO route to be allowed for authenticated users with tokens.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docroot/modules/custom/acquia_id/src/Controller/OAuth2Controller.php |
Allows SSO route access and adds already-logged-in handling for authenticated users with stored tokens. |
docroot/modules/custom/acquia_id/tests/src/Kernel/Controller/OAuth2ControllerTest.php |
Updates the route access expectation for authenticated users with tokens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Trials links to /acquia-id/sso. But once a user is logged in and has a token, that route will return a 403. This was by design and mimics the behavior of the
/user/loginroute from core. But given that Trials links directly to it, we should account for it.Proposed changes
Alternatives considered
In HaaS, the user is linked to an edit page and redirected to login if they're not. So we could do that. But since this is supposed to be a more general solution, I think it makes sense to handle people who arrive on
acquia-id/ssomore gracefully.Testing steps
Current behavior:
New behavior: