CLI-1839: Guard against missing 'type' key in oneOf loop

[deepakmishra2]

Summary

• castParamType accessed $type['type'] unconditionally inside the oneOf loop
• Any oneOf entry without an inline type (e.g. an unresolved $ref) triggered an Undefined array key "type" PHP Warning
• Fix skips entries that lack the type key via array_key_exists guard

Related

• CLI-1839
• CLI-1799 / CLI-1745 (partial fix that resolved top-level $refs but left this oneOf path unguarded)

Test plan

• testCastParamTypeSkipsOneOfEntriesWithoutTypeKey — passes a oneOf spec with a typeless $ref entry alongside an integer entry; confirms the integer cast succeeds with no PHP warnings

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.49%. Comparing base (0d9c5db) to head (b44aff8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2025   +/-   ##
=========================================
  Coverage     92.49%   92.49%           
- Complexity     1991     1992    +1     
=========================================
  Files           123      123           
  Lines          7232     7234    +2     
=========================================
+ Hits           6689     6691    +2     
  Misses          543      543           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2025/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/2025/acli.phar
chmod +x acli.phar

[Copilot]

Pull request overview

Guards ApiBaseCommand::castParamType() against oneOf schema entries that don’t define an inline type (e.g., unresolved $ref entries), preventing PHP warnings during parameter casting in generated API commands.

Changes:

• Skip oneOf entries that lack the type key before accessing $type['type'].
• Add a PHPUnit regression test to ensure typeless oneOf entries don’t trigger warnings and integer casting still works.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Command/Api/ApiBaseCommand.php	Adds a type-key guard inside the oneOf casting loop to avoid undefined-key warnings.
tests/phpunit/src/Commands/Api/ApiCommandTest.php	Adds a regression test covering oneOf entries without type (e.g., $ref).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[deepakmishra2]

The changes done was because composer audit --locked was failing due to these vulnerabilities and dependabot has not yet created a PR to fix this.