CLI-1779: Restrict empty-body JSON fallback to POST only

[deepakmishra2]

Summary

• ApiBaseCommand::execute previously sent {} as a JSON body for any POST/PUT/PATCH with no post params
• For PUT /site-instances/{siteId}.{environmentId}/domains/{domainName} (api:site-instances:domain:add), this triggered curl_setopt_array(): Stream does not support seeking — PHP curl cannot seek on the non-seekable stream Guzzle creates for the empty stdClass
• Fix restricts the empty-body guard to POST only; PUT/PATCH endpoints without a body schema send no body at all

Test plan

• testBodylessPostSendsEmptyJsonBody — POST with no body still sends {}
• testPostWithBodyDoesNotSendEmptyFallback — POST with body does not get the empty fallback
• testBodylessPutDoesNotSendEmptyJsonBody — PUT with no body does NOT send {} (regression test for CLI-1779)
• Run acli api:site-instances:domain:add against a real environment to confirm the PHP warning is gone

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.49%. Comparing base (582c1fb) to head (c7dc3f8).

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2024   +/-   ##
=========================================
  Coverage     92.49%   92.49%           
- Complexity     1992     1994    +2     
=========================================
  Files           123      123           
  Lines          7234     7236    +2     
=========================================
+ Hits           6691     6693    +2     
  Misses          543      543           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/2024/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/2024/acli.phar
chmod +x acli.phar

[Copilot]

Pull request overview

This PR updates ApiBaseCommand::execute() so the “empty JSON body fallback” ({} via Guzzle’s json option) is only applied to POST requests with no request body parameters, avoiding PHP cURL seek warnings for bodyless PUT requests generated from the OpenAPI spec.

Changes:

• Restricts the empty-body JSON fallback to POST requests only in ApiBaseCommand.
• Adds PHPUnit coverage to ensure:
  • bodyless POST sends {} (keeps prior behavior where required),
  • POST with a real body does not send the fallback,
  • bodyless PUT does not send {} (regression coverage for CLI-1779).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Command/Api/ApiBaseCommand.php	Limits the empty {} JSON fallback to POST-only to prevent non-seekable stream issues on bodyless PUT.
tests/phpunit/src/Commands/Api/ApiCommandTest.php	Adds tests covering POST fallback behavior and the PUT regression scenario.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.