fix(feedback): prefer explicit env over implicit ~/.openclaw - #4
Merged
Conversation
Align refine.js and state-sync.template.js so OPENCLAW_HOME / OPENPERSONA_HOME win before default-directory discovery, and lock the precedence with unit + generated-script regression tests. Co-authored-by: Cursor <cursoragent@cursor.com>
The skill-v0.21.1-fixes suite still flakes under node --test IPC on GitHub runners; one retry was not enough. Also disable matrix fail-fast so one Node version does not cancel the others. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveFeedbackDirinlib/lifecycle/refine.jsandtemplates/body/state-sync.template.jsso explicitOPENCLAW_HOME/OPENPERSONA_HOMEwin before implicit~/.openclawdiscoverySIGNAL-PROTOCOL.mdto match the same precedence (and the host-side reference snippet)state-sync.jsregression that writes underOPENPERSONA_HOMEeven when~/.openclawmay existtry/finallyenv cleanupFollow-up to PR #1: keeps the valid bugfix, drops the third-party README example, and finishes the half-applied change so read/write paths stay aligned.
Test plan
node --test tests/refine.test.jsnode --test tests/generator-state-sync.test.jsnpm testMade with Cursor