Fixed typos in da config + everywhere else they were#221
Fixed typos in da config + everywhere else they were#221
Conversation
Deploying hackkit with
|
| Latest commit: |
71f58d7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6f983df.hackkit.pages.dev |
| Branch Preview URL: | https://fix-hk-config-typos.hackkit.pages.dev |
📝 WalkthroughWalkthroughThis PR systematically corrects a typo across the codebase by renaming the misspelled property Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@apps/web/src/lib/constants/index.ts`:
- Line 10: The change to HACKER_REGISTRATION_STORAGE_KEY altered the stored key
(typo fix) and will orphan any in-progress drafts; update the code to handle the
old key by checking for the previous key name
("HackKit_itteration_hackerRegistrationData") and migrating its value to the new
HACKER_REGISTRATION_STORAGE_KEY (or falling back to the old key if present)
before reads/writes. Add the migration logic where
HACKER_REGISTRATION_STORAGE_KEY is used (e.g., the registration save/load helper
or initializer) so existing drafts are preserved and subsequent operations use
the corrected key.
In `@apps/web/src/lib/utils/server/redis.ts`:
- Around line 7-9: Breaking change: includeEnvPrefix switched from using the old
misspelled prefix (c.itteration) to c.iteration which will orphan existing Redis
keys; to avoid data loss restore backward compatibility by updating
includeEnvPrefix to use the original prefix (referencing c.itteration) or
implement a compatibility layer that checks/accepts both prefixes when reading
(and only migrate keys intentionally). Update the includeEnvPrefix function to
reference c.itteration (or add dual-prefix logic) and, if you do intend to
change the canonical prefix, add a documented migration plan for moving existing
keys before deploying.
In `@packages/config/hackkit.config.ts`:
- Around line 985-988: You changed the path used for resume uploads by fixing
the typo in the staticUploads constant (bucketResumeBaseUploadUrl built from
c.hackathonName and c.iteration) which RegisterForm.tsx and
RegisterFormSettings.tsx rely on; verify the infrastructure-migrator migration
script was executed (or run it) before deploying this change so existing resumes
were moved to R2 and DB URLs were updated to the new
/api/upload/resume/view?key=... format—if migration wasn’t run, roll back or run
the migrator and update any DB records pointing to the old itteration-based
paths to the migrated keys to prevent broken resume links.
🧹 Nitpick comments (1)
packages/config/hackkit.config.ts (1)
959-964: MLH badge config changes appear unrelated to the typo fix.The color, foreground, and checked values for the
mlhrole badge have been modified. This is a behavioral change (e.g.,checkedis nowfalse) bundled into a typo-fix PR. Consider noting this in the PR description or splitting it out for clarity.
hi josh i cleaned up very small typos. i wanted to focus more on clubhub but i couldnt let these very small fixes go unnoticed when i was doing cq stuff.
Summary by CodeRabbit