Skip to content

Fixed typos in da config + everywhere else they were#221

Open
vivtratx wants to merge 1 commit intodevfrom
Fix-HK-Config-Typos
Open

Fixed typos in da config + everywhere else they were#221
vivtratx wants to merge 1 commit intodevfrom
Fix-HK-Config-Typos

Conversation

@vivtratx
Copy link
Copy Markdown

@vivtratx vivtratx commented Feb 12, 2026

hi josh i cleaned up very small typos. i wanted to focus more on clubhub but i couldnt let these very small fixes go unnoticed when i was doing cq stuff.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a typo affecting iteration property references across the application, ensuring accurate display of iteration information in event schedules, registration emails, and event passes. Corrected underlying storage keys and Redis prefixes to use the proper property name.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying hackkit with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71f58d7
Status: ✅  Deploy successful!
Preview URL: https://a6f983df.hackkit.pages.dev
Branch Preview URL: https://fix-hk-config-typos.hackkit.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

This PR systematically corrects a typo across the codebase by renaming the misspelled property itteration to iteration in the configuration file and updating all dependent references in template strings and property accesses throughout the application. Additionally, the MLH group object configuration is reformatted for consistency.

Changes

Cohort / File(s) Summary
Configuration & Constants
packages/config/hackkit.config.ts, apps/web/src/lib/constants/index.ts
Renamed exported property itterationiteration in config constant; updated storage key constant to reference corrected property name. MLH group object formatting adjusted with explicit color/foreground/checked values.
Frontend UI Components
apps/web/src/app/dash/page.tsx, apps/web/src/app/dash/pass/page.tsx, apps/web/src/components/schedule/UserScheduleView.tsx, apps/web/src/emails/RegistrationSuccessEmail.tsx
Updated property references in Countdown component, EventPass header, schedule subtitle, and registration email heading from c.itteration to c.iteration.
Backend & Utilities
apps/bot/bot.ts, apps/web/src/lib/utils/server/redis.ts
Corrected template string in bot verification embed and Redis key prefix computation to use c.iteration instead of misspelled c.itteration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A typo once haunted each line with such care,
From itteration to iteration fair!
Across all the files, the fix hops along,
With Redis and emails now singing the song. ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fixed typos in da config + everywhere else they were' is vague and uses colloquial language ('da config') that doesn't clearly convey the specific nature of the changes or the extent of the typo fixes across the codebase. Consider revising the title to be more specific and professional, such as 'Fix itteration typo to iteration across codebase' or 'Correct iteration property name spelling throughout application', which clearly describes the actual changes made.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch Fix-HK-Config-Typos

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In `@apps/web/src/lib/constants/index.ts`:
- Line 10: The change to HACKER_REGISTRATION_STORAGE_KEY altered the stored key
(typo fix) and will orphan any in-progress drafts; update the code to handle the
old key by checking for the previous key name
("HackKit_itteration_hackerRegistrationData") and migrating its value to the new
HACKER_REGISTRATION_STORAGE_KEY (or falling back to the old key if present)
before reads/writes. Add the migration logic where
HACKER_REGISTRATION_STORAGE_KEY is used (e.g., the registration save/load helper
or initializer) so existing drafts are preserved and subsequent operations use
the corrected key.

In `@apps/web/src/lib/utils/server/redis.ts`:
- Around line 7-9: Breaking change: includeEnvPrefix switched from using the old
misspelled prefix (c.itteration) to c.iteration which will orphan existing Redis
keys; to avoid data loss restore backward compatibility by updating
includeEnvPrefix to use the original prefix (referencing c.itteration) or
implement a compatibility layer that checks/accepts both prefixes when reading
(and only migrate keys intentionally). Update the includeEnvPrefix function to
reference c.itteration (or add dual-prefix logic) and, if you do intend to
change the canonical prefix, add a documented migration plan for moving existing
keys before deploying.

In `@packages/config/hackkit.config.ts`:
- Around line 985-988: You changed the path used for resume uploads by fixing
the typo in the staticUploads constant (bucketResumeBaseUploadUrl built from
c.hackathonName and c.iteration) which RegisterForm.tsx and
RegisterFormSettings.tsx rely on; verify the infrastructure-migrator migration
script was executed (or run it) before deploying this change so existing resumes
were moved to R2 and DB URLs were updated to the new
/api/upload/resume/view?key=... format—if migration wasn’t run, roll back or run
the migrator and update any DB records pointing to the old itteration-based
paths to the migrated keys to prevent broken resume links.
🧹 Nitpick comments (1)
packages/config/hackkit.config.ts (1)

959-964: MLH badge config changes appear unrelated to the typo fix.

The color, foreground, and checked values for the mlh role badge have been modified. This is a behavioral change (e.g., checked is now false) bundled into a typo-fix PR. Consider noting this in the PR description or splitting it out for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant