Configuration to file path for attachment#11
Conversation
There was a problem hiding this comment.
I'm using this here instead of model, because model can sometimes be something other than a model for array type fields.
There was a problem hiding this comment.
4 - 28, seems complicated, but it makes 40-43 simple. Any refactoring suggestions?
There was a problem hiding this comment.
check out this awesome storage provider using the target property!
|
Thanks for this - looks like you're putting a ton of work in. I'm away from the computer for a few days - I'll take an in depth look when I get back. |
There was a problem hiding this comment.
Be careful with your casing - the new file is TargetBuilder but you are importing targetBuilder which will work on case-insensitive file systems (e.g. Windows, Mac OS X) but fail on case sensitive ones (e.g. most Linux file systems)
There was a problem hiding this comment.
My bad, missed that in refactoring. In the first pass, targetBuilder was a constructor.
|
@achingbrain I simplified the target builder. |
DO NOT MERGE THIS
this won't pass on travis until the tungus issues are cleared up
I plan on cleaning this up a lot before it's ready to merge. But please provide as much feedback as you can. Thanks!
#10
This is working. However, I had issues with Tungus.
This change sets
targeton the attachment. When then attachment is passed to the storageProvider, the provider can use it or ignore it.targetis set 3 ways.Todo