[WIP] refactor unit test stackItem and stackAll#2
Open
Ilaiwi wants to merge 22 commits into
Open
Conversation
Ilaiwi
changed the title
stackItem and stackAllstackItem and stackAll
convert moment to milliseconds
**Issue Number** namespace-ee#397 replacement because I'm terrible at using git **Overview of PR** Removing the API updates that were accidentally merged in to namespace-ee#397 turned out to be an ordeal. This PR should be cleaner. _Don't forget to update the CHANGELOG.md file with any changes that are in this PR_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes unit testing for
stackItemsandstackAlland refactoring of stackItems.Please read the commits for sequential steps
NaNs in snapshotcanvasWidthcalculations instackItemspropsandstatefromstackItemsto be flat params +canvasWidthas a paramstackItemsstackAll