Add protovalidate annotations to DeviceSpec#3
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
These annotations are equivalent to the validation that bundletool itself performs in DeviceSpecParser.validateDeviceSpec() in bundletool 1.18.1. Adding protovalidate annotations makes it easier for protovalidate-using consumers of android-bundle to validate device specs. The code for the upstream validation method can be found at https://github.com/google/bundletool/blob/1.18.1/src/main/java/com/android/tools/build/bundletool/device/DeviceSpecParser.java#L77.
lberrymage
force-pushed
the
protovalidate-device-spec
branch
from
74d548f to
3bf5945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These annotations are equivalent to the validation that bundletool itself performs in DeviceSpecParser.validateDeviceSpec() in bundletool 1.18.1. Adding protovalidate annotations makes it easier for protovalidate-using consumers of android-bundle to validate device specs.
The code for the upstream validation method can be found at https://github.com/google/bundletool/blob/1.18.1/src/main/java/com/android/tools/build/bundletool/device/DeviceSpecParser.java#L77.