[mlir][dxsa] Add dcl_thread_group instruction#121
Open
tagolog wants to merge 1 commit into
Open
Conversation
asl
reviewed
May 1, 2026
asl
reviewed
May 1, 2026
| //===----------------------------------------------------------------------===// | ||
|
|
||
| LogicalResult DclThreadGroup::verify() { | ||
| auto total = uint64_t(getX()) * uint64_t(getY()) * uint64_t(getZ()); |
Contributor
There was a problem hiding this comment.
do you really need cast here? individual operand checks enforces ranges, and 64 * 1024 * 1024 does not overflow 32-bit type.
Contributor
There was a problem hiding this comment.
Looks like we still cast to int64_t in DclThreadGroup::verify.
asl
reviewed
May 1, 2026
asl
reviewed
May 1, 2026
tagolog
force-pushed
the
dxsa-mlir-dcl_thread_group
branch
from
a89b52d to
d02c638
Compare
asl
reviewed
May 8, 2026
Example: dxsa.dcl_thread_group<x = 1, y = 1, z = 1> Signed-off-by: Vladimir Shiryaev <tagolog@users.noreply.github.com>
tagolog
force-pushed
the
dxsa-mlir-dcl_thread_group
branch
from
d02c638 to
3285a60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
dxsa.dcl_thread_group<x = 1, y = 1, z = 1>