Skip to content

Fix building the release binaries - #170

Merged
abusch merged 2 commits into
mainfrom
fix-release-binaries
Oct 15, 2026
Merged

abusch merged 2 commits into
mainfrom
fix-release-binaries

Conversation

@abusch

@abusch abusch commented Oct 15, 2026

Copy link
Copy Markdown
Owner

The release binaries job failed for v0.2.0 (run).

What happened

Only aarch64-unknown-linux-musl failed: the other eight targets were cancelled by the matrix's default fail-fast, before they started.

The musl targets are built with cross, which couldn't read Cargo.toml:

expected a table key, found a newline at line 25 column 11

The rustls and tracing-subscriber dependencies were written as multi-line inline tables. That's TOML 1.1 syntax, which recent Cargo accepts but cross's TOML parser doesn't.

Changes

  • Write those two dependencies on one line each, like the others. A TOML 1.0 parser (toml 0.8) rejects the released Cargo.toml and accepts this one.
  • Turn off fail-fast in the binaries matrix, so one broken target doesn't cancel the others.

After merging

  • Running "Release binaries" by hand for v0.2.0 should attach the seven non-musl binaries. The musl ones will fail again, because the tag has the old Cargo.toml.
  • release-plz will propose v0.2.1 for the fix; releasing it builds all nine.

🤖 Generated with Claude Code

@abusch
abusch merged commit dc29e33 into main Oct 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant