Repository navigation
feat(update): add per-release runtime notice dismissal - #332
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
CI follow-up at 3deadee: canonicalize only the isolated test fixture root, so macOS /var aliases do not prevent positive fixtures from exercising the preference logic. The production no-follow guard is unchanged. A real ancestor-symlink regression still refuses reads/writes without effects, while the explicitly resolved fixture succeeds. A synthetic alias reproduces the original unsafe-versus-missing failure signature; the historical runner path itself was not printed, so that exact path is not asserted. Python 3.9 and 3.13: 62 focused preference/update tests OK each (one existing permission-enforcement skip on the approved external test volume). No runtime, documentation, version or permission relaxation. New-head CI is pending. |
|
Exact-head CI verification: 3deadee now has 28/28 successful checks, including both previously failing macOS Python jobs and the release gate. The macOS Python 3.9 log explicitly reports test_native_private_path_when_filesystem_enforces_metadata and test_temporary_root_alias_refuses_while_resolved_fixture_succeeds as OK (not skipped). This supplies real runner owner/mode-path evidence separate from the locally controlled-metadata fixtures; it does not prove ACL audit, arbitrary filesystem support or all deployment environments. |
Summary
Adds an explicit, local preference for dismissing the automatic runtime notice for one stable release (#294):
update --dismiss-runtime-notice VERSIONandupdate --clear-runtime-notice-dismissalare offline preference operations, mutually exclusive with checking and all remote/SSH options. They never install, fetch, approve or mark a release current.Refs #294
Validation
-X dev -W error::ResourceWarning: 1,355 tests OK (20 skips). The initial pre-review candidate also passed 1,352 tests; the final run includes the added review regressions and reviewed translation corrections.git diff --checkpass. Tests require the actual generated standalone artifact, not a source fallback.The approved local temp volume ignores ownership. Controlled-metadata fixtures use actual directory-relative I/O, inode checks, locks, fsync and atomic replacement; they are not native permission certification. The unmocked positive test skips on unsafe real ancestors and is intended to execute on an owner-enforcing Linux CI filesystem. No internal-disk permission-test exception or volume/global permission change was used.
Independent review
Before PR publication,
independent-cli-reviewran Claude Code 2.1.308 (requested/observed modelclaude-opus-5-5) and Codex CLI 0.163.0 (isolated default; actual model not exposed) in parallel with identical read-only, frozen, self-contained source/test/document excerpts. Both completed with exit 0; Claude reported no error, Codex completed its turn with zero command-execution events, and the input remained unchanged (SHA-2565cad25dcb2732491872345adaf0858914c960210a1a40e0a0baaa222da004718). No runtime execution by the reviewers is claimed.Root-verified corrections: inode-bound cleanup on temporary validation failure, inherited setgid-compatible private mode checks, unambiguous check wording, removal of test source fallbacks, real-CLI remote-check advisory/result separation, and an inherited four-locale correction that newer remote runtimes are not downgraded. The original input overclaimed that an actual remote CLI check never reads the caller's local preference; this was a wording error, not a remote comparison defect. The intended local ambient advisory reads once and does not hide remote versions/results. Narrow corrections were separately source-audited and regression-tested; no claim that the two CLIs re-reviewed the final corrected revision. CLI agreement is not proof of correctness.
Limits
Translation quality review
At the user's request, Antigravity CLI 1.4.5 explicitly selected the available
gemini-3.8-flash-mediummodel with medium effort, plan mode, sandbox and a five-minute limit. The task-local runner omitted permission bypasses; one fresh read-only review completed with exit 0 and structured output (149.536 seconds). The input contained the complete changed Updating section in English/Korean/Japanese/Simplified Chinese, with commands and surrounding context (20,196 bytes, SHA-256c3e614fbbc308019f200239b1abd412dd5b42ccf49d0509c9dc5028b0dcd8dd3). The model selector is recorded; an independent backend identity is not exposed by the result.Codex checked suggestions against the English source and applied precise fallback/ACL wording, invalid/future-schema file subjects, Japanese cache-write wording, and the Chinese newer-version distinction. Flags, code blocks, paths, numbers and behavioral limits remain unchanged. This is static linguistic/semantic QA, not native execution, CI evidence, security certification or native-speaker field testing. Final local docs checks are recorded separately.