Repository navigation
ops: prepare a 24-claim recovery operating limit - #81
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Operating rollout verified — 2026-11-01 (KST)Merged PR #81 ( The owner's execution result reported Independent post-application checks confirmed:
No test claim, replayed callback, injected outage or Dots package/runtime update was performed. This completes only the operating-cap slice of #80; budget diagnostics, early warnings and temporary escalation remain open. #79's acknowledged-but-unclaimed follow-up gap is unchanged. |
Problem and resulting change
The operating broker reached its rolling 12-claim limit and correctly refused a new outage despite qualifying for the 600-second confirmed-recovery interval. This PR prepares an explicit 24-claim operating allowance without changing the package default of 3 or the configured 3600/600-second intervals.
Refs #80. This is its narrowly requested cap-change slice; diagnostics, warning notifications and temporary escalation remain open. #79 is a separate received-but-unclaimed event gap.
Implementation
--max-claims-per-24hto the reviewed policy deployment helper. Omission preserves the existing value/implicit default; explicit values are strict integers 1..24, and invalid existing settings are rejected before override.local_coordinationconstructor argument without altering it, so the helper supports the current server shape and preserves connector extensions.Validation and review
Local research suite: 256 tests, OK (one expected macOS skip). Source-manifest and Python static checks passed. Tests exercise 12→24 on the same SQLite ledger, mixed outcome accounting, the 24th/25th boundary and rolling expiry, CLI propagation, budget-only code/config preservation, omitted/default behavior, idempotency and failure rollback.
Independent read-only Claude Code and Codex CLI review used identical frozen inputs in two rounds. Required documentation clarification and recommended fixture/rollback checks were addressed; final review results and CI are added below. These model reviews are source analysis, not live deployment evidence.
Operating boundary
No operating deployment or policy mutation occurred. The default example stays recovery-disabled; package/runtime executable sources and their manifest are unchanged. The root helper still refuses open outages or in-flight delivery, so deployment needs a separate reviewed healthy maintenance point. Raising the cap does not fix the recurring disconnects or guarantee Dots execution. No merge, release or production restart is requested by this PR itself.
Independent review evidence
48ede9afc7efc8b38b09eadf20ad405225ce2216ccfcc129070f1766670c5df0; revisedb186aafb1540065d61d10e1cc293321d17271605c6183cf22a72fd5acfc70d5b. All input hashes were rechecked.load_recovery24/25 test were subsequently checked by Codex and a read-only final subagent gate. Production helper code is byte-identical to the second reviewed revision. English/Korean command blocks match.CI result
All push and pull-request checks passed at
69c8571d988a6f3b2578256253ad413c80b94cd8: Python 3.11/3.13 core tests, Research Python 3.12/3.13 (including lifecycle), Python static checks, Shell syntax/ShellCheck and GitGuardian. PR is Ready, mergeable and unmerged.