Resolve Google Drive iOS DriveKit joins within one container - #2004
Merged
Conversation
The local file, thumbnail, item and comment artifacts looked up Drive metadata by account and item id. One device carries several DriveKit stores, an account appeared in more than one container on each tested image, and a Drive item id is the same string wherever it is cached, so that key let one container's cache answer for another's. All four lookups now key on container, account and item id. This prevents a mix rather than repairing an observed one: where a pair was cached in two containers the values agreed, so a before and after across eight images shows the same rows and the same values. Attribution is untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the DriveKit metadata joins within the container the file sits in.
Correctness by construction rather than a repair: an account appears in more than one container on each tested image, but where a pair was cached twice the containers agreed on title, mime type and trash state, so a before and after across eight images shows the same rows and the same values. Before trusting that, the comparison was shown to fire by injecting one wrong title into a copy of a real output.
Baseline is the current main behaviour, which is byte identical to the merged commit, so only the eight fix side sweeps were run. Attribution is untouched.