Add Korean (ko) localization for Volo.Abp.Validation module#25788
Open
moduvoice wants to merge 1 commit into
Open
Add Korean (ko) localization for Volo.Abp.Validation module#25788moduvoice wants to merge 1 commit into
moduvoice wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This adds Korean (
ko) translation support — to help Korean-speaking users use thisopen-source project more comfortably in their own language.
(한국 사람들의 오픈소스 이용에 도움이 되게 하기 위해서 한글화 작업을 하였습니다.)
ABP is a very large framework with hundreds of modules, so this PR starts with the
Volo.Abp.Validationmodule (one of the smallest open-source core packages) as a firststep; additional modules will follow in separate PRs.
(abp는 모듈이 수백 개인 대형 프레임워크이므로, 이번 PR에서는 오픈소스 코어 패키지 중 가장 작은 축에
속하는
Volo.Abp.Validation모듈부터 시작합니다. 이후 다른 모듈들은 별도의 PR로 추가할 예정입니다.)Changes
framework/src/Volo.Abp.Validation/Volo/Abp/Validation/Localization/ko.jsonAbpValidationModulealready loads alllocalization files in this folder via
AddVirtualJson("/Volo/Abp/Validation/Localization"),so the new
ko.jsonfile is picked up automatically.Testing
ko.jsoncontains exactly the same set and order of keys asen.json(34/34 keys, no missing/extra/empty values) using a Python script comparing both
JSON files'
textsobjects.json.load).docs/en/contribution/index.md,which does not require a pre-registered issue for open-source core modules
(only commercial modules require an issue first).