Fix OSV to handle affected_packages correctly & add support to collect commits #2080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziadhany
force-pushed
the
osv-migration
branch
from
91b89f3 to
ab084af
Compare
Collaborator
Author
|
OSV Logs , importers:
|
Add support to collect commits Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Use parse_advisory_data_v3 for GitHub OSV. Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Update the function docs osv_v2 Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Fix CVSSv4 vector length issue Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
…es to keep ranges consistent. Signed-off-by: ziad hany <ziadhany2016@gmail.com>
ziadhany
force-pushed
the
osv-migration
branch
from
ebaee7d to
b6bf165
Compare
TG1999
reviewed
Dec 29, 2025
| { | ||
| "reference_id": "", | ||
| "reference_type": "", | ||
| "url": "http://git.fedorahosted.org/cgit/freeipa.git/commit/?id=a1991aeac19c3fec1fdd0d184c6760c90c9f9fc9" |
Contributor
There was a problem hiding this comment.
Can we classify them as commit type ?
Collaborator
Author
There was a problem hiding this comment.
The problem is that this is passed as part of the reference URLs, so it’s not easy to detect whether it’s a commit URL or just an article. We have already classified some of these as reference_type=commit because they were passed as a Git range.
I think one option is to improve our capabilities to parse different commit URLs in the packageurl-python library and rely on improvers like pipelines/v2_improvers/collect_commits.py to handle this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: