Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
131f976
ci: scope push trigger to main to drop redundant PR runs (#802)
abnobdoss Jul 4, 2026
b7b0470
chore(deps): bump actions/setup-python from 6.2.0 to 6.3.0 (#813)
dependabot[bot] Jul 6, 2026
d068a81
chore(deps): bump actions/cache from 5.0.5 to 6.1.0 (#814)
dependabot[bot] Jul 6, 2026
c3bc646
chore(deps): bump actions/cache/restore from 5.0.5 to 6.1.0 (#815)
dependabot[bot] Jul 6, 2026
fce18ea
chore(deps): bump actions/cache/save from 5.0.5 to 6.1.0 (#816)
dependabot[bot] Jul 6, 2026
5d31dee
refactor: move typed arrow Append helpers to ArrowRowBuilder (#821)
WZhuo Jul 7, 2026
f4f6359
build: scope warnings-as-error to project targets, not FetchContent s…
yadavay-amzn Jul 7, 2026
ebc0e07
Infra: Group github/codeql-action bumps into a single dependabot PR (…
ebyhr Jul 11, 2026
4c906d1
feat: make ToLower Unicode-aware via utf8proc (#760)
goel-skd Jul 11, 2026
b4737df
fix: generate public API docs correctly (#804)
zhjwpku Jul 11, 2026
a45bce6
chore(deps): bump the codeql-action group with 2 updates (#827)
dependabot[bot] Jul 11, 2026
3d5af47
fix: return error for reserved property keys in UpdateProperties::Set…
WZhuo Jul 11, 2026
62e1bd8
feat: support v3 column default values in UpdateSchema (#793)
huan233usc Jul 11, 2026
aa36d35
ci: add RelWithDebInfo build and fix free-nonheap-object error (#812)
zhjwpku Jul 11, 2026
755799d
refactor: use decimal high and low for Arrow scalar (#803)
zhjwpku Jul 11, 2026
263795e
build: add benchmark build scaffolding (#825)
timothyw553 Jul 12, 2026
2191844
build: enable clang-tidy misc-include-cleaner for include hygiene (#820)
yadavay-amzn Jul 12, 2026
0825f56
ci: retry build dir cleanup on Windows (#807)
abnobdoss Jul 12, 2026
fee1884
ci: build Windows test leg in Debug (#806)
abnobdoss Jul 14, 2026
330de84
feat(puffin): support deletion-vector-v1 blob read/write (#777)
zhaoxuan1994 Jul 14, 2026
697891b
fix: use kLegacyPartitionDataIdStart as partition field ID baseline (…
WZhuo Jul 15, 2026
c5a5b5c
feat: merge multiple deletion vectors per data file (#708)
HuaHuaY Jul 16, 2026
155e484
ci: share sccache setup across workflows
abnobdoss Jul 3, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/actions/save-sccache/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

name: Save sccache
description: Show sccache stats and save the cache on main branch runs after setup-sccache.

inputs:
key-prefix:
description: Cache key prefix without the run id or Windows compiler suffix.
required: true

runs:
using: composite
steps:
- name: Show sccache stats
if: always()
shell: bash
run: sccache --show-stats

- name: Save sccache cache
if: ${{ github.ref == 'refs/heads/main' }}
uses: actions/cache/save@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ github.workspace }}/.sccache
key: ${{ inputs.key-prefix }}${{ env.SCCACHE_KEY_SUFFIX }}-${{ github.run_id }}
55 changes: 55 additions & 0 deletions .github/actions/sccache/resolve-msvc-key-suffix.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

# Resolve the MSVC toolset version for use as an sccache cache key suffix.
# GitHub runner images roll out new cl.exe builds roughly weekly; keying the
# cache on the toolset version avoids silent misses after each bump.

$PSNativeCommandUseErrorActionPreference = $false

function Resolve-Suffix {
# Locate vswhere, which ships with every VS installation.
$vswhere = Join-Path ${env:ProgramFiles(x86)} 'Microsoft Visual Studio\Installer\vswhere.exe'
if (-not (Test-Path $vswhere)) { return $null }

# Ask vswhere for the newest installation that includes the C++ toolset.
$installationPath = (& $vswhere -latest -products * `
-requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 `
-property installationPath | Select-Object -First 1)
if (-not $installationPath) { return $null }

# Read the default toolset version (e.g. "14.44.35217").
$versionFile = Join-Path $installationPath.Trim() 'VC\Auxiliary\Build\Microsoft.VCToolsVersion.default.txt'
if (-not (Test-Path $versionFile)) { return $null }

$version = (Get-Content -Path $versionFile -Raw).Trim()
if ($version) { return "-$version" }
return $null
}

$suffix = Resolve-Suffix
if (-not $suffix) {
# Degrade gracefully: a shared bucket is better than a failed build.
$suffix = '-unknown'
Write-Host "::warning::could not resolve MSVC toolset version for sccache key, using '$suffix'"
}

# Export to both step outputs (for setup-sccache's restore key) and env (for
# save-sccache's save key later in the same job).
Add-Content -Path $env:GITHUB_OUTPUT -Value "suffix=$suffix"
Add-Content -Path $env:GITHUB_ENV -Value "SCCACHE_KEY_SUFFIX=$suffix"
Write-Host "Resolved SCCACHE_KEY_SUFFIX=$suffix"
57 changes: 57 additions & 0 deletions .github/actions/setup-sccache/action.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

name: Set up sccache
description: Configure sccache, restore its cache, and start the sccache action.

inputs:
key-prefix:
description: Cache key prefix without the run id or Windows compiler suffix.
required: true
cache-size:
description: Maximum sccache cache size.
required: false
default: 2G

runs:
using: composite
steps:
- name: Configure sccache environment
shell: bash
run: |
echo "SCCACHE_DIR=${{ github.workspace }}/.sccache" >> "$GITHUB_ENV"
echo "SCCACHE_CACHE_SIZE=${{ inputs.cache-size }}" >> "$GITHUB_ENV"
echo "SCCACHE_KEY_SUFFIX=" >> "$GITHUB_ENV"

# Windows caches include the MSVC toolset version because GitHub runner image
# rollouts can change the compiler while keeping the same image label.
- name: Resolve MSVC toolset version for sccache key
if: ${{ runner.os == 'Windows' }}
id: msvc-key
shell: pwsh
run: '& "${{ github.action_path }}/../sccache/resolve-msvc-key-suffix.ps1"'

- name: Restore sccache cache
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ github.workspace }}/.sccache
key: ${{ inputs.key-prefix }}${{ steps.msvc-key.outputs.suffix }}-${{ github.run_id }}
restore-keys: |
${{ inputs.key-prefix }}${{ steps.msvc-key.outputs.suffix }}-

- name: Setup sccache
uses: mozilla-actions/sccache-action@9e7fa8a12102821edf02ca5dbea1acd0f89a2696 # v0.0.10
7 changes: 7 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,10 @@ updates:
day: "sunday"
cooldown:
default-days: 7
groups:
# The codeql-action init/autobuild/analyze steps must all run the
# same version - split PRs cause a version mismatch that fails the
# Analyze jobs. Group them so a single PR bumps all of them together.
codeql-action:
patterns:
- "github/codeql-action*"
4 changes: 2 additions & 2 deletions .github/workflows/asf-allowlist-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
name: "ASF Allowlist Check"

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- main
pull_request:
types: [opened, synchronize, reopened, ready_for_review]

permissions:
contents: read
Expand Down
104 changes: 8 additions & 96 deletions .github/workflows/aws_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ name: AWS Tests
on:
push:
branches:
- '**'
- '!dependabot/**'
- main
tags:
- '**'
pull_request:
Expand Down Expand Up @@ -74,8 +73,6 @@ jobs:
AWS_DEFAULT_REGION: us-east-1
AWS_ENDPOINT_URL: http://127.0.0.1:9000
AWS_EC2_METADATA_DISABLED: "TRUE"
SCCACHE_DIR: ${{ github.workspace }}/.sccache
SCCACHE_CACHE_SIZE: "2G"
steps:
- name: Checkout iceberg-cpp
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
Expand All @@ -87,7 +84,7 @@ jobs:
run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev libjitterentropy3-dev
- name: Cache vcpkg packages
if: ${{ startsWith(matrix.runs-on, 'ubuntu') && matrix.bundle_awssdk == 'OFF' }}
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
id: vcpkg-cache
with:
path: /usr/local/share/vcpkg/installed
Expand Down Expand Up @@ -115,101 +112,16 @@ jobs:
if: ${{ matrix.s3 == 'ON' }}
shell: bash
run: bash ci/scripts/start_minio.sh
- name: Restore sccache cache
uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
- name: Set up sccache
uses: ./.github/actions/setup-sccache
with:
path: ${{ github.workspace }}/.sccache
key: sccache-aws-${{ matrix.runs-on }}-bundle${{ matrix.bundle_awssdk }}-s3${{ matrix.s3 }}-sigv4${{ matrix.sigv4 }}-${{ github.run_id }}
restore-keys: |
sccache-aws-${{ matrix.runs-on }}-bundle${{ matrix.bundle_awssdk }}-s3${{ matrix.s3 }}-sigv4${{ matrix.sigv4 }}-
- name: Setup sccache
uses: mozilla-actions/sccache-action@9e7fa8a12102821edf02ca5dbea1acd0f89a2696 # v0.0.10
key-prefix: sccache-aws-${{ matrix.runs-on }}-bundle${{ matrix.bundle_awssdk }}-s3${{ matrix.s3 }}-sigv4${{ matrix.sigv4 }}
- name: Build and test Iceberg
shell: bash
env:
CMAKE_TOOLCHAIN_FILE: ${{ startsWith(matrix.runs-on, 'ubuntu') && matrix.bundle_awssdk == 'OFF' && '/usr/local/share/vcpkg/scripts/buildsystems/vcpkg.cmake' || '' }}
run: ci/scripts/build_iceberg.sh "$(pwd)" OFF ON ${{ matrix.s3 }} ${{ matrix.sigv4 }} ${{ matrix.bundle_awssdk }}
- name: Show sccache stats
shell: bash
run: sccache --show-stats
- name: Save sccache cache
if: github.ref == 'refs/heads/main'
uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
with:
path: ${{ github.workspace }}/.sccache
key: sccache-aws-${{ matrix.runs-on }}-bundle${{ matrix.bundle_awssdk }}-s3${{ matrix.s3 }}-sigv4${{ matrix.sigv4 }}-${{ github.run_id }}

# Exercise the Meson build with SigV4 enabled (resolves aws-cpp-sdk-core via
# its CMake config, not pkg-config whose Cflags force -std=c++11).
meson-sigv4:
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Meson SigV4 (AMD64 Ubuntu 26.04)
runs-on: ubuntu-26.04
timeout-minutes: 45
env:
SCCACHE_DIR: ${{ github.workspace }}/.sccache
SCCACHE_CACHE_SIZE: "2G"
steps:
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.x'
- name: Checkout iceberg-cpp
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
persist-credentials: false
- name: Install build dependencies
shell: bash
run: |
sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev libjitterentropy3-dev
python3 -m pip install --upgrade pip
python3 -m pip install -r requirements.txt
- name: Cache vcpkg packages
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
id: vcpkg-cache
with:
path: /usr/local/share/vcpkg/installed
key: vcpkg-x64-linux-aws-sdk-cpp-core-${{ hashFiles('.github/workflows/aws_test.yml') }}
- name: Install AWS SDK via vcpkg
if: ${{ steps.vcpkg-cache.outputs.cache-hit != 'true' }}
shell: bash
# Retry to ride out transient GitHub/mirror download failures (504s).
run: |
for attempt in 1 2 3; do
if vcpkg install aws-sdk-cpp[core]:x64-linux; then
exit 0
fi
echo "::warning::vcpkg install failed (attempt ${attempt}/3), retrying in 30s"
sleep 30
done
echo "::error::vcpkg install failed after 3 attempts"
exit 1
- name: Set Ubuntu Compilers
# Wrap the compiler with sccache: Meson uses an explicit CC/CXX verbatim,
# so the launcher must be prepended here to route compiles through sccache.
run: |
echo "CC=sccache gcc-14" >> $GITHUB_ENV
echo "CXX=sccache g++-14" >> $GITHUB_ENV
- name: Restore sccache cache
uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
with:
path: ${{ github.workspace }}/.sccache
key: sccache-meson-sigv4-${{ github.run_id }}
restore-keys: |
sccache-meson-sigv4-
- name: Setup sccache
uses: mozilla-actions/sccache-action@9e7fa8a12102821edf02ca5dbea1acd0f89a2696 # v0.0.10
- name: Build and test Iceberg
shell: bash
env:
CMAKE_PREFIX_PATH: /usr/local/share/vcpkg/installed/x64-linux
run: |
meson setup builddir -Dsigv4=enabled
meson compile -C builddir
sccache --show-stats
meson test -C builddir --timeout-multiplier 0 --print-errorlogs
- name: Save sccache cache
if: github.ref == 'refs/heads/main'
uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5.0.5
- name: Save sccache
uses: ./.github/actions/save-sccache
with:
path: ${{ github.workspace }}/.sccache
key: sccache-meson-sigv4-${{ github.run_id }}
key-prefix: sccache-aws-${{ matrix.runs-on }}-bundle${{ matrix.bundle_awssdk }}-s3${{ matrix.s3 }}-sigv4${{ matrix.sigv4 }}
10 changes: 6 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ name: "CodeQL"

on:
push:
branches: [ "main" ]
branches:
- main
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
branches: [ "main" ]
branches:
- main
schedule:
- cron: '16 4 * * 1'

Expand Down Expand Up @@ -52,11 +54,11 @@ jobs:
persist-credentials: false

- name: Initialize CodeQL
uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
uses: github/codeql-action/init@54f647b7e1bb85c95cddabcd46b0c578ec92bc1a # v4.36.3
with:
languages: actions

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2
uses: github/codeql-action/analyze@54f647b7e1bb85c95cddabcd46b0c578ec92bc1a # v4.36.3
with:
category: "/language:actions"
Loading
Loading