Skip to content

ci: build Windows test leg in Debug - #21

Open
abnobdoss wants to merge 2 commits into
mainfrom
ci/windows-debug-test-leg
Open

abnobdoss wants to merge 2 commits into
mainfrom
ci/windows-debug-test-leg

Conversation

@abnobdoss

Copy link
Copy Markdown
Owner

No description provided.

@abnobdoss
abnobdoss force-pushed the ci/windows-debug-test-leg branch 5 times, most recently from 1e8445b to e072b11 Compare July 3, 2026 04:29
Flip the SQL Catalog workflow's Windows matrix entry from Release to
Debug so every SQL Catalog leg builds Debug. This relies on the MSVC
sccache handling from the previous commit, which makes Debug objects
cacheable via embedded /Z7 debug info.
@abnobdoss
abnobdoss force-pushed the ci/windows-debug-test-leg branch from e072b11 to baaab05 Compare July 13, 2026 19:32
@github-actions

Copy link
Copy Markdown

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v22.1.2) reports: 31 concern(s)
  • src/iceberg/arrow/literal_util.cc:127:19: warning: [misc-include-cleaner]

    no header providing "std::make_shared" is directly included

      127 |       return std::make_shared<::arrow::Decimal128Scalar>(arrow_decimal,
          |                   ^
  • src/iceberg/arrow_row_builder.cc:114:38: warning: [misc-include-cleaner]

    no header providing "uint64_t" is directly included

      114 | Status AppendUInt(ArrowArray* array, uint64_t value) {
          |                                      ^
  • src/iceberg/arrow_row_builder.cc:124:45: warning: [misc-include-cleaner]

    no header providing "std::string_view" is directly included

       22 | Status AppendString(ArrowArray* array, std::string_view value) {
          |                                             ^
  • src/iceberg/arrow_row_builder.cc:130:55: warning: [misc-include-cleaner]

    no header providing "uint8_t" is directly included

      130 | Status AppendBytes(ArrowArray* array, std::span<const uint8_t> value) {
          |                                                       ^
  • src/iceberg/arrow_row_builder.cc:138:59: warning: [misc-include-cleaner]

    no header providing "int32_t" is directly included

      138 | Status AppendIntList(ArrowArray* array, const std::vector<int32_t>& values) {
          |                                                           ^
  • src/iceberg/arrow_row_builder.cc:179:12: warning: [misc-include-cleaner]

    no header providing "iceberg::InvalidArrowData" is directly included

      179 |     return InvalidArrowData("Map array must have exactly 2 children.");
          |            ^
  • src/iceberg/catalog/rest/http_request.h:25:1: warning: [misc-include-cleaner]

    included header algorithm is not used directly

       25 | #include <algorithm>
          | ^~~~~~~~~~~~~~~~~~~~
       26 | #include <cctype>
  • src/iceberg/manifest/manifest_adapter.cc:134:40: warning: [misc-include-cleaner]

    no header providing "std::vector" is directly included

       22 |             child_array, std::get<std::vector<uint8_t>>(partition_value.value())));
          |                                        ^
  • src/iceberg/manifest/manifest_adapter.cc:134:47: warning: [misc-include-cleaner]

    no header providing "uint8_t" is directly included

      134 |             child_array, std::get<std::vector<uint8_t>>(partition_value.value())));
          |                                               ^
  • src/iceberg/manifest/manifest_adapter.cc:187:61: warning: [misc-include-cleaner]

    no header providing "iceberg::ToString" is directly included

       27 |         ICEBERG_RETURN_UNEXPECTED(AppendString(child_array, ToString(file.file_format)));
          |                                                             ^
  • src/iceberg/schema_field.cc:38:6: warning: [misc-include-cleaner]

    no header providing "std::shared_ptr" is directly included

       23 | #include <string_view>
       24 | #include <utility>
       25 | #include <variant>
       26 | 
       27 | #include "iceberg/expression/literal.h"
       28 | #include "iceberg/type.h"
       29 | #include "iceberg/util/checked_cast.h"
       30 | #include "iceberg/util/formatter.h"  // IWYU pragma: keep
       31 | #include "iceberg/util/macros.h"
       32 | 
       33 | namespace iceberg {
       34 | 
       35 | namespace {
       36 | 
       37 | // Treat null defaults as absent.
       38 | std::shared_ptr<const Literal> DropNullDefault(std::shared_ptr<const Literal> value) {
          |      ^
  • src/iceberg/schema_field.cc:99:1: warning: [misc-include-cleaner]

    no header providing "iceberg::Result" is directly included

       28 | Result<Literal> SchemaField::CastDefaultValue(
          | ^
  • src/iceberg/schema_field.cc:101:33: warning: [misc-include-cleaner]

    no header providing "iceberg::TypeId" is directly included

       29 |   if (target_type->type_id() == TypeId::kDecimal &&
          |                                 ^
  • src/iceberg/schema_field.cc:102:30: warning: [misc-include-cleaner]

    no header providing "iceberg::Decimal" is directly included

       30 |       std::holds_alternative<Decimal>(value.value())) {
          |                              ^
  • src/iceberg/schema_field.cc:108:16: warning: [misc-include-cleaner]

    no header providing "iceberg::InvalidArgument" is directly included

      108 |         return InvalidArgument("Cannot cast default value to {}: {}", *target_type,
          |                ^
  • src/iceberg/test/string_util_test.cc:167:14: warning: [misc-include-cleaner]

    no header providing "std::vector" is directly included

       21 |   const std::vector<std::string> atoms = {
          |              ^
  • src/iceberg/test/string_util_test.cc:172:3: warning: [misc-include-cleaner]

    no header providing "size_t" is directly included

       21 |   size_t generation_begin = 0;
          |   ^
  • src/iceberg/test/update_schema_test.cc:35:1: warning: [misc-include-cleaner]

    included header schema.h is not used directly

       35 | #include "iceberg/schema.h"
          | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
       36 | #include "iceberg/schema_field.h"
  • src/iceberg/test/update_schema_test.cc:69:57: warning: [misc-include-cleaner]

    no header providing "size_t" is directly included

       22 |                                           std::optional<size_t> length) {
          |                                                         ^
  • src/iceberg/test/update_schema_test.cc:70:36: warning: [misc-include-cleaner]

    no header providing "iceberg::FileIO" is directly included

       35 |           return mock_file_io_ptr->FileIO::ReadFile(file_location, length);
          |                                    ^
  • src/iceberg/test/update_schema_test.cc:77:21: warning: [misc-include-cleaner]

    no header providing "std::move" is directly included

       28 |     file_io_ = std::move(mock_file_io);
          |                     ^
  • src/iceberg/test/update_schema_test.cc:95:24: warning: [misc-include-cleaner]

    no header providing "std::move" is directly included

       95 |     RegisterTable(std::move(metadata));
          |                        ^
  • src/iceberg/test/update_schema_test.cc:221:55: warning: [misc-include-cleaner]

    no header providing "int64_t" is directly included

       22 |                     Literal::Long(std::numeric_limits<int64_t>::max()));
          |                                                       ^
  • src/iceberg/util/string_util.cc:30:6: warning: [misc-include-cleaner]

    no header providing "std::string" is directly included

       25 | 
       26 | #include "iceberg/util/macros.h"
       27 | 
       28 | namespace iceberg {
       29 | 
       30 | std::string StringUtils::ToLower(std::string_view str) {
          |      ^
  • src/iceberg/util/string_util.cc:30:39: warning: [misc-include-cleaner]

    no header providing "std::string_view" is directly included

       25 | 
       26 | #include "iceberg/util/macros.h"
       27 | 
       28 | namespace iceberg {
       29 | 
       30 | std::string StringUtils::ToLower(std::string_view str) {
          |                                       ^
  • src/iceberg/util/string_util.cc:64:31: warning: [misc-include-cleaner]

    no header providing "size_t" is directly included

       25 |                   static_cast<size_t>(written));
          |                               ^
  • src/iceberg/util/string_util.cc:70:1: warning: [misc-include-cleaner]

    no header providing "iceberg::Result" is directly included

       26 | Result<std::vector<uint8_t>> StringUtils::HexStringToBytes(std::string_view hex) {
          | ^
  • src/iceberg/util/string_util.cc:70:13: warning: [misc-include-cleaner]

    no header providing "std::vector" is directly included

       25 | Result<std::vector<uint8_t>> StringUtils::HexStringToBytes(std::string_view hex) {
          |             ^
  • src/iceberg/util/string_util.cc:70:20: warning: [misc-include-cleaner]

    no header providing "uint8_t" is directly included

       25 | Result<std::vector<uint8_t>> StringUtils::HexStringToBytes(std::string_view hex) {
          |                    ^
  • src/iceberg/util/type_util.cc:402:42: warning: [misc-include-cleaner]

    no header providing "std::move" is directly included

      402 |   return std::make_shared<ListType>(std::move(fresh_elem_field));
          |                                          ^
  • src/iceberg/util/type_util.cc:420:15: warning: [misc-include-cleaner]

    no header providing "std::make_shared" is directly included

      420 |   return std::make_shared<MapType>(std::move(fresh_key_field),
          |               ^

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant