Repository navigation
Conversation
Default all platforms to Debug (was Release on Windows, Debug on Unix). Build only the shared library (was both static and shared). The release candidate workflow already validates Release builds on all platforms.
Vendored Boost hits PDB lock contention (C1041) when building Debug with Ninja parallelism. The /Z7 flag was only applied when sccache was the compiler launcher; apply it for all MSVC Debug builds.
The per-flag string replacement only affects the default CMAKE_*_FLAGS but vendored Boost overrides them with target-level /Zi, causing PDB lock contention under Ninja. CMP0141 + CMAKE_MSVC_DEBUG_INFORMATION_FORMAT forces /Z7 for all targets including FetchContent dependencies.
Replace constexpr static PartitionValues with inline static const since PartitionValues has a virtual base class (not a literal type). MSVC Debug correctly rejects this; GCC/Clang are lenient. Use generator expressions for test link targets so tests resolve whichever library variant is available (static or shared).
Shared-only had unresolved export issues in tests. Static-only achieves the same target reduction and tests already link static.
abnobdoss
force-pushed
the
ci/test-header-blast
branch
from
June 30, 2026 03:55
596da9e to
e29678f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.