Repository navigation
doctor: skip validator checks on non-validators; show warnings as ! - #24
Open
abhijitkrm wants to merge 1 commit into
Open
abhijitkrm wants to merge 1 commit into
abhijitkrm wants to merge 1 commit into
Conversation
Archive, RPC and sentry nodes don't sign, so doctor no longer runs the signing-health and jail checks on them (a profile with no role, or one saved with a valoper, still gets them). Their "skipped" result was also drawn as a failure: a warning with detail text got the ✗ mark. Warnings now always show "!". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing primium-scripts' new
--post-setupmode:cometcli doctoron an archive node showed two ✗ lines (signing health, jail status), saying it "can't tell which validator this node is".Two bugs
Validator checks ran on every node. Signing health and jail status now run only when the profile:
Archive, RPC and sentry nodes skip them.
Warnings were drawn as failures. The icon switch checked
!OK && Detail != ""beforeWarn, so any warning with detail text showed ✗. That affected the "skipped" lines above and others such as "upgrade pending". Warnings now always show!. The failure and warning counts were already right; only the mark was wrong.Tested live (primium-6)
missed 0/1000,not jailedgo test ./...passes. New tests:TestSignsBlocks(each role, plus the valoper override) andTestDoctorIcon.The remaining
✗ key file permson both nodes is a real finding: the node'sconfig/anddata/folders are 0755.🤖 Generated with Claude Code