Conversation
|
Conflicts already?! |
* Use <u> instead of <i>, because Chinese italics is woe
We are going to have Taiwanese and Hong Kongese friends eventually, so let's be more specific.
Mostly issues with punctuation and how line breaks create spaces, but some sentences were reworded for clarity too.
I am very unsure about this new logic. Perl, welp.
... using the two commands I used to use half a decade ago: * opencc -c s2twp * sed -e 's/“/「/g' -e 's/”/」/g' -e 's/‘/『/g' -e 's/’/』/g'
|
I have to say the merge of @libkoi's PR was less than fortunate. Anyways, I took some of libkoi's translation during conflict resolution, but mostly kept mine -- partly because the file move confuses git's three way display on some files, so I am not even seeing the changed text... In other words... @abh good to merge again, please review. |
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on improving Chinese-language support by updating language identifiers, translations, and alias handling while also including several documentation updates. Key changes include:
- Renaming the key "zh" to "zh_CN" and adding "zh_TW" in the language mappings.
- Updating translation files (.po) to modify the formatting tags and wording.
- Revising several documentation pages in both Traditional and Simplified Chinese.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/NTPPool/Control.pm | Updated language mappings and enhanced alias resolution in Perl code. |
| i18n/zh_TW.po and i18n/zh.po | Modified translation strings for consistency and formatting. |
| docs/ntppool/zh_TW/* and docs/ntppool/zh_CN/use.html | Updated documentation content in Traditional and Simplified Chinese. |
| docs/ntppool/zh/use.html | Removed outdated Simplified Chinese use guidance. |
| return first { | ||
| s/-/_/g; | ||
| $valid_languages{$_} // $valid_languages{$language_aliases{$_}} | ||
| } @languages; |
There was a problem hiding this comment.
[nitpick] Using the in-place substitution operator within the 'first' block reduces readability. Consider preprocessing the language list by replacing '-' with '_' before applying the 'first' function to improve clarity.
| return first { | |
| s/-/_/g; | |
| $valid_languages{$_} // $valid_languages{$language_aliases{$_}} | |
| } @languages; | |
| my @processed_languages = map { my $lang = $_; $lang =~ s/-/_/g; $lang } @languages; | |
| return first { | |
| $valid_languages{$_} // $valid_languages{$language_aliases{$_}} | |
| } @processed_languages; |
|
@Artoria2e5 sorry to not get on this sooner; I need to review fixing the language codes to not just be the two letter ones. There's CDN configuration that only supports two letter codes currently, so I have to work through that and see if I can work through it so the "simple" languages where the two letter code is fine can continue to work as-is. |
abh
force-pushed
the
main
branch
3 times, most recently
from
b215a04 to
1ab7f20
Compare
|
More conflicts... okay. |
2 participants
A lot of things changed here:
The most dubious thing here is the perl code. Please, tell me if it's working at all.