Keep menu results responsive to touch without pointer motion - #741
Open
marksverdhai wants to merge 1 commit into
Open
marksverdhai wants to merge 1 commit into
marksverdhai wants to merge 1 commit into
Conversation
Owner
|
can you fix the conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touch-only dmenu users can lose item activation after the query changes or keyboard navigation:
disable_mouse()turns off GTK hit testing for the result list, and only subsequent pointer motion restores it. This also affects successive Omarchy submenus.Add opt-in
touch_mode = trueto keep results targetable. The default remains false, and explicitdisable_mousestill takes precedence. This preserves GTK's single-tap activation and swipe scrolling without changing menu actions or layouts.Validation: the configuration opt-in/opt-out test passes, formatting and diff checks pass, and the same simulated Linux touchscreen tap returned no selection before the fix and the intended second item afterward. A swipe produced no accidental activation, then a tap selected item 7. A single touch also opened the Learn submenu in the real Omarchy menu.
Fixes #740.