fix: AGE label creation race condition on first ingest#353
Merged
Conversation
Migration 058 explicitly creates all 7 vertex labels, 10 static edge labels, and 30 vocabulary edge labels before any ingestion can run. AGE auto-creates labels on first CREATE/MERGE, but this is a DDL operation (CREATE TABLE) that races under concurrent ingestion threads, causing "relation 'Source' already exists" on fresh installs.
The existing code detected "already exists" as an expected race but still raised the exception. Now retries up to 2 times with rollback between attempts, so concurrent label auto-creation is transparent. Defense in depth for any labels not covered by migration 058.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_execute_cypherfor"already exists"race conditions — the existing detection logged but never retriedFailed to create Source node: relation "Source" already existson fresh install first ingestRoot cause
AGE auto-creates labels on first
CREATE (s:Source {...})via implicit DDL (CREATE TABLE). When concurrent worker threads hit an empty graph simultaneously, the DDL races and the loser gets a PostgreSQL duplicate relation error.Test plan
./operator.sh init)kg admin workersshows no failed jobs