Skip to content

fix(windows): avoid nested PowerShell runner - #137

Merged
aannoo merged 1 commit into
mainfrom
fix/windows-runner-launch-flake
Sep 13, 2026
Merged

aannoo merged 1 commit into
mainfrom
fix/windows-runner-launch-flake

Conversation

@aannoo

@aannoo aannoo commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • invoke generated Windows runner scripts inside the existing PowerShell host
  • remove the redundant nested PowerShell startup that intermittently stalled before hcom pty
  • add non-sensitive background-runner stage breadcrumbs for future launch diagnostics
  • add cross-platform unit coverage for runner invocation quoting and breadcrumb ordering

Evidence

The observed Windows Claude CI failure left both PowerShell hosts alive for 96 seconds, printed only Starting Claude..., and never spawned hcom pty. The unchanged rerun passed. Direct invocation removes the stalled process boundary.

Verification

  • just ci (10/10 steps passed)
  • focused runner invocation and Windows script-generation tests

@aannoo
aannoo merged commit d542a9f into main Sep 13, 2026
42 checks passed
orgoj added a commit to orgoj/hcom that referenced this pull request Sep 13, 2026
… module)

Upstream fabb309 brings the runner Node-precedence fix (aannoo#117), the grown
CODEX_HOME resolution (aannoo#115), Ptyxis support (aannoo#113), the Windows nested
PowerShell removal (aannoo#137) and the kimi modularisation (aannoo#106).

Conflicts resolved in upstream's favour:
- codex.rs / codex_preprocessing.rs: the fork's cherry-picked 080c78a used a
  thread-local CODEX_HOME override; upstream's explicit `*_at` threading
  replaces it, so the wrapper functions and the thread-local are dropped.
- launcher.rs: upstream's case-insensitive effective-env helpers and the
  earlier canonical_dir are taken; the fork's per-instance system-prompt
  path stays and upstream's global gemini system-prompt block is dropped.
- kimi: upstream's src/hooks/kimi/ module replaces the fork's kimi.rs (it
  already carries the fork's lifecycle and observation fixes); only the
  fork's nested-identity gate `hook_gate_check_for_tools` is re-applied.
- terminal_presets: expected preset count raised to 30 for Ptyxis.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WDRs6TVA2uSBXG2TQacFRf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant