fix(transcript): make prefix resolution literal and unambiguous - #129
Merged
aannoo merged 4 commits intoSep 13, 2026
Merged
Conversation
…tion and ambiguity fail-closed (SOL-004 RED)
…ctive prefix candidates
…iguity (SOL-004 GREEN)
marcelokarval
force-pushed
the
fix/transcript-literal-prefix-resolution
branch
from
September 4, 2026 06:56
c7eb543 to
e374bef
Compare
marcelokarval
marked this pull request as ready for review
September 4, 2026 07:01
swaynehales
added a commit
to swaynehales/hcom
that referenced
this pull request
Sep 9, 2026
Adopt upstream PR aannoo#129 by @marcelokarval at e374bef.
Owner
|
thanks |
orgoj
added a commit
to orgoj/hcom
that referenced
this pull request
Sep 13, 2026
- fc2276d (aannoo#123) was already in this fork as the cherry-picks bb67813 / ddc2383. Upstream's own version has since grown a remote path, so the conflict in transcript.rs is resolved entirely in upstream's favor: no_transcript_error now takes display_name plus an optional device and suggests `hcom events --remote-fetch --device <D> --participant <name>` for a remote agent. The fork's smoke test from 7a1a92f was asserting the older `--agent` wording and now asserts `--participant`. - 8719445 (aannoo#129) makes transcript prefix resolution literal and fails closed on ambiguity, with exact identity authoritative. - 9a0f3be (aannoo#127) releases the command-owned database handle before reset/archive so Windows can archive a live connection, and preserves pending delivery on non-destructive paths. Verified: cargo fmt --check, clippy --all-targets clean, 2325 unit tests pass, cli_smoke 67 pass (copilot/cursor/pi real-tool tests excluded on this machine). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XckU8sHdJf22MHeGUyd7Gm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LIKEpatternsWhy
The previous fallback used
LIKE '<input>%' LIMIT 1. Inputs containing_or%therefore behaved as SQL wildcards, and ambiguous prefixes selected whichever row SQLite returned first. Either path could show a different agent's transcript.Verification
_, literal%, and ambiguous prefixescargo clippy --locked --bin hcom -- -D warningscargo fmt -- --checkFixes #128