mon, crush: Allow new pools with different CRUSH rules#8
Open
Ericmzhang wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
build/ops
common
config-change
core
documentation
Ericmzhang
force-pushed
the
wip-stretch-replica-device-classes
branch
from
6325af8 to
15aebd7
Compare
github-actions
Bot
added
ceph-volume
cephadm
cephfs
CI
crimson
dashboard
mgr
nfs
orchestrator
pybind
rbd
rgw
script
labels
Change validation to check each shadow tree has at least num_replica_zone hosts and osds Signed-off-by: Eric Zhang <emzhang@ibm.com>
Added validation that new pools in stretch mode have CRUSH rules that stretch across the same sites. Allow mixing of stretch pools with different device classes and CRUSH rules Signed-off-by: Eric Zhang <emzhang@ibm.com>
…g CRUSH rules Tests for allowing mixed device classess and different CRUSH rules Test validation preventing adding new pools in stretch mode with CRUSH rules across different sites Signed-off-by: Eric Zhang <emzhang@ibm.com>
Ericmzhang
force-pushed
the
wip-stretch-replica-device-classes
branch
from
15aebd7 to
39c2fb3
Compare
bill-scales
reviewed
May 19, 2026
| if (ss) { | ||
| *ss << "CRUSH rule " << new_crush_rule << " is stretched across " << crush.get_type_name(dividing_id) | ||
| << " instead of " << crush.get_type_name(osdmap.stretch_mode_bucket); | ||
| } |
Collaborator
There was a problem hiding this comment.
Missing return -EINVAL; ??
| } | ||
| return -EINVAL; | ||
| } | ||
| return 0; |
Collaborator
There was a problem hiding this comment.
Why return after checking just one stretch pool?
Collaborator
Author
There was a problem hiding this comment.
I was assuming that since we are validating that all stretch pools have the same peering_crush_bucket_count, peering_crush_bucket_target, peering_crush_bucket_barrier, and that the crush rules stretch across the same sites, then we would only need to check one pool since we guarantee all pools have the same settings. Would it be better to check all the pools?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable device classes for stretch mode by allowing new stretch mode pools to have different CRUSH rules.
Add validation that pools with different CRUSH rules must be stretched across the same sites (same bucket_count, bucket_target and bucket_barrier)
Added bash tests to verify
Signed-off-by: Eric Zhang emzhang@ibm.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.