mon: auto generate ec profile when creating a new pool#3
Open
CJamesIBM wants to merge 9 commits into
Open
Conversation
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Previously bitset set did not exploit its bit-set nature by providing bitshift and other logical operators. Here we add <<, >>, <<=, >>=, &, |, &= Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Previously, there was no way of swapping out a transaction intended for one shard and applying it a different shard. This kind of functionality is very useful for EC stretched mode, as we often want to send the same transaction to two different shards. Due to the way transactions store a table of objects, it turns out that this is surprisingly simply process! Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
This commit reflects an old design. We put the num_zones in the profile. Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
Author
|
Documentation probably needs updating |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Introduces three new optional parameters to 'osd pool create' command (ec_k, ec_m, ec_num_zones) that enable automatic EC profile creation alongside pool creation. The num_zones parameter is moved from the EC profile level to the pool level. Signed-off-by: Callum James <callum.james@ibm.com>
CJamesIBM
force-pushed
the
ec_stretch_auto_profile
branch
from
49bc846 to
a4b4458
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces 3 new variables to pool creation;
If K and M are provided as args to osd pool create a k+m EC profile will be automatically created, other profile values are taken from the default ec profile.
num_zones can be optionally provided to overwrite the default value of 1.
Various logic is introduced to maintain old style profile / pool creation, handle conflicting profiles and unsupported values of k, m and num_zones.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.