build(deps): Migrate Google ADK and ADK-A2A from v0.9.0 to v1.5.0#1754
Open
theyihlin wants to merge 4 commits into
Open
build(deps): Migrate Google ADK and ADK-A2A from v0.9.0 to v1.5.0#1754theyihlin wants to merge 4 commits into
theyihlin wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades the Google ADK dependency from version 0.9.0 to 1.5.0 across multiple build files and refactors session management in A2aHandler to use SessionKey instead of individual string parameters. Feedback suggests using Kotlin's Elvis operator (?:) in getOrCreateSession to simplify the control flow and avoid mutable variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the
google-adkandgoogle-adk-a2adependencies to the latest stable version1.5.0, keeping the A2UI Kotlin SDK aligned with the latest ADK specification and capabilities. Per the integration plan, thea2a-java-sdk-clientdependency remains untouched at1.0.0.Alpha3.Key Changes
1. Dependency Upgrades
com.google.adk:google-adkandcom.google.adk:google-adk-a2ato1.5.0in:agent_sdks/kotlin/build.gradle.ktssamples/community/agent/adk/rizzcharts/java/build.gradle.ktssamples/community/agent/adk/rizzcharts/kotlin/build.gradle.kts2. Session Lifecycle Refactoring (
SessionKeyIntegration)A2aHandlerto construct theSessionKeyat the very beginning of the RPC handling block.SessionKeydirectly to a refinedgetOrCreateSession(sessionKey)method and torunner.runAsync(...). This unifies the lifecycle aroundSessionKeyand removes parameter duplication.getOrCreateSessionto utilize the new ADK v1.5.0 two-parameter signature:getSession(SessionKey, GetSessionConfig?)passingnullfor the config, which replaces the legacy JavaOptionalwrapper.3. Test Suite Adjustments
A2aConformanceTest.kt: Updated the mock runner expectations to match the newSessionKeyand two-parametergetSessionsignatures.AdkExtensionsConformanceTest.kt: Added mock stubbing forPart.partMetadata()on the mocked GenAIPartobject to preventMockKExceptioncaused by internal calls inside the new ADK v1.5.0 event converter.Verification
ktfmt.