fix(angular): use Angular signals directly#1733
Open
crisbeto wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the Angular renderer from using bridged Preact signals to natively using Angular signals, removing the @preact/signals-core dependency and updating services and tests accordingly. The review feedback highlights a critical issue in initializeAngularReactivity where multiple active EnvironmentInjector instances can interfere with each other's lifecycles, potentially resetting the signal implementation prematurely or throwing errors. A stack-based approach is suggested to safely track and clean up active injectors.
Reworks the Angular renderer to use Angular signals directly based on the APIs from a2ui-project#1714, instead of having to bridge Angular and Preact signals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the Angular renderer to use Angular signals directly based on the APIs from #1714, instead of having to bridge Angular and Preact signals.