feat(explorer): add integration tests for new example json files#1702
Open
josemontespg wants to merge 4 commits into
Open
feat(explorer): add integration tests for new example json files#1702josemontespg wants to merge 4 commits into
josemontespg wants to merge 4 commits into
Conversation
…ngular, lit, and react
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive test suites for the Angular, Lit, and React renderers covering various UI layout and interaction scenarios, updates an import path in the Angular custom slider component, and configures the TypeScript base URL. The review feedback focuses on improving the Angular test files by recommending explicit TypeScript type casting for queried DOM elements to ensure strict type safety, and suggesting the use of specific component class selectors (such as .a2ui-button) instead of generic HTML tags to prevent matching unintended elements.
ditman
approved these changes
Jun 18, 2026
ditman
left a comment
ditman
left a comment
Collaborator
There was a problem hiding this comment.
This LGTM! If CI is happy, I'm happy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explorer integration tests for the new example json files in angular, lit, and react. Relates to #1497.
Fixes #1646