-
Notifications
You must be signed in to change notification settings - Fork 331
Update to specification from 1e5f46206403982cc629a0dad535856b28c269aa #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to specification from 1e5f46206403982cc629a0dad535856b28c269aa #617
Conversation
Summary of ChangesHello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request brings a significant update to the A2A protocol specification, focusing on enhancing clarity, consistency, and functionality. It introduces tenant-aware operations across various API calls, renames several fields and methods to improve semantic meaning, and refines field requirements for better data integrity. Key additions include a new task listing capability and an extended agent card retrieval, alongside updated documentation to reflect these changes and align with the latest protocol version. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates generated code to align with version 0.3.0 of the A2A specification. This update introduces significant breaking changes, including renamed RPC methods and message fields, and adds new features. While the generated files themselves appear correct, the PR is critically incomplete because it does not update the client, server, and test code that consumes this generated code. This will cause the build to fail. To proceed, the PR must be updated to include all necessary changes in the dependent files to ensure they are compatible with the new specification.
Commit: a2aproject/A2A@1e5f462