-
Notifications
You must be signed in to change notification settings - Fork 106
feat: TCK SUT requires authentication #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jmesnil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces basic authentication to the TCK's System Under Test (SUT). It integrates Quarkus's built-in security features to enable HTTP Basic Authentication, defining a simple user credential within the application properties. This change ensures that the TCK can properly test scenarios requiring authenticated access, enhancing the robustness of the test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces basic authentication for the TCK SUT. The changes include adding the necessary Quarkus security dependency, updating the agent card to advertise the security scheme, and configuring an embedded user in application.properties. My review focuses on improving security practices by avoiding plain-text passwords, ensuring correctness in the agent card definition, and addressing an incomplete feature implementation. All comments align with project guidelines or are not covered by specific rules, and are therefore kept as is.
Use a simple properties file with 1 user credential. This requires the TCK to be configured to use HTTP basic authentication in its .env): ``` A2A_AUTH_TYPE=basic A2A_AUTH_USERNAME=alice A2A_AUTH_PASSWORD=a2a-p4ssw0rd ```` Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
c0bdbcc to
147da79
Compare
Signed-off-by: Jeff Mesnil <jmesnil@ibm.com>
Use a simple properties file with 1 user
credential.
This requires the TCK to be configured to use HTTP basic authentication in its .env):