Skip to content

[Refactor] Remove no-explicit-any suppressions: batch 2 (small directories) - #2286

Merged
edelauna merged 2 commits into
mainfrom
chore/remove-any-suppressions-batch-2
Nov 1, 2026
Merged

edelauna merged 2 commits into
mainfrom
chore/remove-any-suppressions-batch-2

Conversation

@zoomote2

@zoomote2 zoomote2 Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

No GitHub issue was supplied for this maintenance batch. This PR continues the no-explicit-any suppression-removal campaign and follows batch 1 in #2281.

Description

This is batch 2 of the no-explicit-any suppression-removal campaign. It clears all 224 suppressions in root-level files, i18n, __mocks__, extension, shared, activate, and the root __tests__ directory.

The changes use precise inferred types, existing domain types, generics, and unknown with narrowing. Test doubles now use real public method and payload signatures. The TaskEvents domain map now declares the three task-level delegation payloads used by the extension API. Test assertions and intended runtime behavior stay unchanged. No webview-ui, integrations, services, api, or core suppression entries were removed.

The suppression ledger was pruned with ESLint. Against the latest rebased main, it shrinks from 3,541 to 3,317 suppressions and from 325 to 292 files. Exactly 33 scoped entries were removed. No entries were added, no remaining counts changed, and no out-of-scope entries were removed.

Test Procedure

Validation completed on the rebased branch unless noted otherwise:

  • Focused Vitest run for every touched suite: 19 files and 232 tests passed.
  • pnpm lint: 12 tasks passed with zero warnings.
  • pnpm check-types: 11 tasks passed.
  • pnpm --dir src test: 552 files and 12,003 tests passed; 4 files and 39 tests skipped. Missing distribution assets were built before this successful run.
  • Full repo-wide pnpm test: 14 of 14 tasks passed.
  • Prettier check for all changed files: passed.
  • Ledger comparison against origin/main: exactly 33 scoped entries removed, with no additions, changed remaining entries, or out-of-scope removals.

The first repo-wide test run hit the known order-dependent flake in src/__tests__/extension.spec.ts: two focus-tracker tests failed. The suite passed in isolation with 24 of 24 tests, and the required repo-wide rerun passed all 14 tasks. No changes were made to address that known flake.

Pre-Submission Checklist

  • Issue Linked: No GitHub issue was supplied for this batch. The campaign and batch 1 ([Refactor] Remove no-explicit-any suppressions: batch 1 (utils) #2281) are linked above instead.
  • Scope: The changes are limited to the seven requested directory groups and the type declarations required by those fixes.
  • Self-Review: I reviewed the complete diff, including the rebased conflict resolution and final staged paths.
  • Writing Style: The PR title and description use short sentences and plain, active language.
  • Testing: Existing focused and full suites cover these type-only changes. No new runtime behavior required new tests.
  • Test Helpers: Test doubles were updated in place. No shared helpers were added, and scenario-specific mocks and assertions remain visible.
  • Visual Snapshot: Not applicable. This PR has no UI changes.
  • Documentation Impact: No documentation updates are required for this internal type-only refactor.
  • Contribution Guidelines: I read and agree to the Contributor Guidelines.

Visual Snapshots

Not applicable. This PR has no user-visible interface changes.

Videos (interaction / animation only)

Not applicable. This PR has no interaction or animation changes.

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Additional Notes

The branch contains one commit and is rebased onto origin/main at 997f5d822. Batch 1 was delivered in #2281.

Get in Touch

Discord: 7777777

@coderabbitai

coderabbitai Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • coderabbit-review-active

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zoomote2

zoomote2 Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor Author

No new code issues found in the new changes. The added delegation-event forwarding suite matches the listener semantics in extension/api.ts and the TaskEvents/TaskProviderEvents payload declarations, and follows the AGENTS.md typed-test conventions. See session

  • src/activate/__tests__/handleUri.spec.ts:20 — double assertions (as unknown as ClineProvider) missing the AGENTS.md-required comment naming the members the double provides; also src/__tests__/api-subtask.spec.ts:69.

Reviewed fff23ed

@zoomote2

zoomote2 Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Self-review complete. I reviewed all 35 changed files and the final rebased diff. I found no blocking issues.

Review notes:

  • The changes are type-only. Test assertions and intended runtime behavior are unchanged.
  • Public provider and task methods are called without casts. Private state uses bracket access where required.
  • The three task-level delegation payloads in TaskEvents match the listeners in extension/api.ts.
  • The rebase conflict in activate/__tests__/registerCommands.spec.ts preserves the upstream retryWebviewRecovery doubles and this batch's typed evictCurrentTask / refreshWorkspace members.
  • The ledger removes exactly the 33 scoped entries: 3,541 → 3,317 suppressions and 325 → 292 files against latest main. No entries were added or moved.

Validation evidence is in the PR body. The post-rebase focused run passed 19 files / 232 tests, lint and type checks are green, and the earlier full gates passed 12,003 extension tests plus all 14 repo-wide test tasks. The known focus-tracker flake appeared once, passed in isolation, and the repo-wide rerun passed.

@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: The required review sequence passed. Remaining merge requirements apply.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

edelauna
edelauna previously approved these changes Nov 1, 2026
@edelauna
edelauna marked this pull request as ready for review November 1, 2026 16:54
@github-actions github-actions Bot added the awaiting-maintainer CodeRabbit approved; waiting for a human maintainer label Nov 1, 2026
@edelauna
edelauna force-pushed the chore/remove-any-suppressions-batch-2 branch from 18046c1 to fff23ed Compare November 1, 2026 17:27
@github-actions github-actions Bot added awaiting-maintainer CodeRabbit approved; waiting for a human maintainer and removed awaiting-maintainer CodeRabbit approved; waiting for a human maintainer labels Nov 1, 2026
@edelauna
edelauna added this pull request to the merge queue Nov 1, 2026
@github-actions github-actions Bot removed the awaiting-maintainer CodeRabbit approved; waiting for a human maintainer label Nov 1, 2026
Merged via the queue into main with commit 1d78f74 Nov 1, 2026
23 checks passed
@edelauna
edelauna deleted the chore/remove-any-suppressions-batch-2 branch November 1, 2026 18:24
edelauna added a commit that referenced this pull request Nov 2, 2026
…ories) (#2286)

* refactor: remove no-explicit-any suppressions in small directories

* test: expand URI callback coverage and address review feedback

---------

Co-authored-by: Roomote <roomote@roomote.dev>
Co-authored-by: Elliott de Launay <edelauna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants