Repository navigation
[Refactor] Remove no-explicit-any suppressions: batch 2 (small directories) - #2286
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
|
No new code issues found in the new changes. The added delegation-event forwarding suite matches the listener semantics in
Reviewed fff23ed |
|
Self-review complete. I reviewed all 35 changed files and the final rebased diff. I found no blocking issues. Review notes:
Validation evidence is in the PR body. The post-rebase focused run passed 19 files / 232 tests, lint and type checks are green, and the earlier full gates passed 12,003 extension tests plus all 14 repo-wide test tasks. The known focus-tracker flake appeared once, passed in isolation, and the repo-wide rerun passed. |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
18046c1 to
fff23ed
Compare
…ories) (#2286) * refactor: remove no-explicit-any suppressions in small directories * test: expand URI callback coverage and address review feedback --------- Co-authored-by: Roomote <roomote@roomote.dev> Co-authored-by: Elliott de Launay <edelauna@gmail.com>
Related GitHub Issue
No GitHub issue was supplied for this maintenance batch. This PR continues the no-explicit-any suppression-removal campaign and follows batch 1 in #2281.
Description
This is batch 2 of the no-explicit-any suppression-removal campaign. It clears all 224 suppressions in root-level files,
i18n,__mocks__,extension,shared,activate, and the root__tests__directory.The changes use precise inferred types, existing domain types, generics, and
unknownwith narrowing. Test doubles now use real public method and payload signatures. TheTaskEventsdomain map now declares the three task-level delegation payloads used by the extension API. Test assertions and intended runtime behavior stay unchanged. Nowebview-ui,integrations,services,api, orcoresuppression entries were removed.The suppression ledger was pruned with ESLint. Against the latest rebased
main, it shrinks from 3,541 to 3,317 suppressions and from 325 to 292 files. Exactly 33 scoped entries were removed. No entries were added, no remaining counts changed, and no out-of-scope entries were removed.Test Procedure
Validation completed on the rebased branch unless noted otherwise:
pnpm lint: 12 tasks passed with zero warnings.pnpm check-types: 11 tasks passed.pnpm --dir src test: 552 files and 12,003 tests passed; 4 files and 39 tests skipped. Missing distribution assets were built before this successful run.pnpm test: 14 of 14 tasks passed.origin/main: exactly 33 scoped entries removed, with no additions, changed remaining entries, or out-of-scope removals.The first repo-wide test run hit the known order-dependent flake in
src/__tests__/extension.spec.ts: two focus-tracker tests failed. The suite passed in isolation with 24 of 24 tests, and the required repo-wide rerun passed all 14 tasks. No changes were made to address that known flake.Pre-Submission Checklist
Visual Snapshots
Not applicable. This PR has no user-visible interface changes.
Videos (interaction / animation only)
Not applicable. This PR has no interaction or animation changes.
Documentation Updates
Additional Notes
The branch contains one commit and is rebased onto
origin/mainat997f5d822. Batch 1 was delivered in #2281.Get in Touch
Discord: 7777777