Repository navigation
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
 |
| Layer / File(s) | Summary |
|---|---|
Expose and verify the none option webview-ui/src/components/settings/providers/OpenAICompatible.tsx, webview-ui/src/components/settings/providers/__tests__/OpenAICompatible.spec.tsx, webview-ui/src/components/settings/__tests__/ThinkingBudget.spec.tsx, src/api/providers/__tests__/openai.spec.ts |
The provider lists "none" as a supported reasoning-effort value. Tests cover its availability, persistence when selected, and inclusion in a streaming request with the read_file tool. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature · Severity of issue fixed: Medium
Merge Risk: 
ea64a
-
The change appears ready to merge after normal checks. No merge-blocking issue was identified.
Pre-merge checks: 
-
Check name Status Explanation Resolution Regression Evidence The PR adds a user-visible noneoption atwebview-ui/src/components/settings/providers/OpenAICompatible.tsx:333, but it adds no Playwright component snapshot. The existing visual fixtures cover Az…Add a Playwright gallery story and committed component snapshot for the OpenAI-compatible reasoning-effort control with reasoning enabled. Open the selector or otherwise render its options so the noneoption and the resulting visible stat…Description check The description links issue #2040and explains the implementation and scope. However, the Test Procedure is empty, and the required pre-submission checklist remains unchecked.Add reproducible test steps and relevant environment details. Complete the pre-submission checklist, including the testing and documentation items. -
Check name Status Explanation Linked Issues check Issue #2040requires a way to sendreasoning_effort: "none"for OpenAI-compatible chat-completions requests, or to route requests through/v1/responses. This PR implements the settings path: `Open…Out of Scope Changes check The changed provider setting exposes the option required by issue #2040. The API regression test verifies the required request behavior. The settings tests verify persistence and supported-option wiri…Security Boundaries No changed path violates the security boundaries. The only production change adds the fixed value "none"to the OpenAI-compatible reasoning-effort option list in `webview-ui/src/components/settings/…Persistence Integrity No changed persistence defect exists. The PR only adds the "none" option and tests. Selecting it synchronously updates openAiCustomModelInfo.reasoningEffortthroughOpenAICompatible.tsx; `Settings…Lifecycle Resource Cleanup No changed lifecycle path can leak a resource or duplicate work. The only production change adds "none" to the existing supportsReasoningEffortarray inOpenAICompatible.tsx. Other changes add tes…Title check The title clearly and concisely describes the main change: exposing the nonereasoning-effort option for OpenAI-compatible models.
Full details: Regression Evidence
-
Explanation
The PR adds a user-visible
noneoption atwebview-ui/src/components/settings/providers/OpenAICompatible.tsx:333, but it adds no Playwright component snapshot. The existing visual fixtures cover Azure guidance and Extra Body only, andThinkingBudget.visual.tsxcovers a Bedrock budget slider. Vitest tests cover option wiring and persistence, but they do not provide the required durable visual evidence for the changed settings UI.Resolution
Add a Playwright gallery story and committed component snapshot for the OpenAI-compatible reasoning-effort control with reasoning enabled. Open the selector or otherwise render its options so the
noneoption and the resulting visible state are covered.
-
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Review statusThanks for contributing. This comment tracks the review sequence and the next action. Current step: Mark the PR ready. Required CI must pass before CodeRabbit starts. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
github-actions
Bot
added
coderabbit-review-active
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
github-actions
Bot
added
awaiting-maintainer
github-actions
Bot
added
awaiting-ready
…ase URLs in OpenAiNativeHandler
github-actions
Bot
removed
the
awaiting-ready
…le-reasoning-effort-none
Related GitHub Issue
Closes: #2040
Description
Added the none reasoning-effort option for OpenAI-compatible models. Selecting it saves the setting and includes none in API requests; tests cover settings and request construction in OpenAICompatible.tsx and openai.spec.ts.
Reviewer note: the option is now exposed for all OpenAI-compatible models, without checking endpoint-specific support.
Test Procedure
Pre-Submission Checklist
*.visual.tsxsnapshot inwebview-ui/. Seewebview-ui/AGENTS.md→ "When a UI change needs a snapshot".Visual Snapshots
Videos (interaction / animation only)
Documentation Updates
Additional Notes
Get in Touch