fix: send review to terminal respects repo default agent setting#17
Open
Ziinc wants to merge 1 commit into
Open
fix: send review to terminal respects repo default agent setting#17Ziinc wants to merge 1 commit into
Ziinc wants to merge 1 commit into
Conversation
handleCreateAgentWithReview in ShowWorkspace was calling onSessionCreated without an agent field, so the session always launched with the claude agent regardless of the repo or app default_agent setting. Now it reads the repo-level default_agent first (falling back to the app-level default), and passes the resolved agent to onSessionCreated, matching the same resolution logic used when creating sessions from the task input. Also adds getRepoSetting to the api mock in ShowWorkspace test files to avoid falling through to the real implementation when the review handler is invoked in tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA8qrRVMGszi1yK9gnjXKW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleCreateAgentWithReview in ShowWorkspace was calling onSessionCreated
without an agent field, so the session always launched with the claude
agent regardless of the repo or app default_agent setting.
Now it reads the repo-level default_agent first (falling back to the
app-level default), and passes the resolved agent to onSessionCreated,
matching the same resolution logic used when creating sessions from the
task input.
Also adds getRepoSetting to the api mock in ShowWorkspace test files to
avoid falling through to the real implementation when the review handler
is invoked in tests.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01EA8qrRVMGszi1yK9gnjXKW