Skip to content

fix(deps): override adm-zip to 0.6.0 in workbench#3

Merged
Skiipy11 merged 2 commits into
mainfrom
steward/workbench-audit-adm-zip
Jul 19, 2026
Merged

fix(deps): override adm-zip to 0.6.0 in workbench#3
Skiipy11 merged 2 commits into
mainfrom
steward/workbench-audit-adm-zip

Conversation

@Skiipy11

@Skiipy11 Skiipy11 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Main and Renovate lockfile PRs (#1/#2) fail Workbench (Node 22) on:

npm audit --audit-level=highadm-zip < 0.6.0 via @huggingface/transformersonnxruntime-node.

This PR adds overrides["adm-zip"] = "0.6.0" and refreshes workbench/package-lock.json.

Path gate

Only workbench package manifest + lockfile.

Notes

  • Local pre-push semgrep fails on pre-existing main-tree findings unrelated to this diff; CI is the merge gate.
  • Repo hygiene has also been red on main since 2026-07-10 (added-commit boundary fallback) and may still block merge.

Test plan

  • local npm audit --audit-level=high clean after override
  • local workbench tests 379 passed (excluding env-only node:sqlite suite)
  • CI Workbench (Node 22)

Summary by CodeRabbit

  • Chores
    • Updated a bundled package version to improve compatibility and reliability.

Workbench CI fails npm audit --audit-level=high via
@huggingface/transformers → onnxruntime-node → adm-zip@0.5.x (GHSA-xcpc-8h2w-3j85).

Force adm-zip@0.6.0 through npm overrides and refresh the lockfile.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 298b903f-d2a3-4f6e-8809-d39cd7b48c67

📥 Commits

Reviewing files that changed from the base of the PR and between 9133b87 and 3b2d3b2.

⛔ Files ignored due to path filters (1)
  • workbench/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • workbench/package.json

📝 Walkthrough

Walkthrough

The workbench package configuration adds an adm-zip override at version 0.6.0, alongside the existing esbuild override.

Changes

Dependency Override

Layer / File(s) Summary
Add adm-zip override
workbench/package.json
The overrides section now pins adm-zip to version 0.6.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: overriding adm-zip to 0.6.0 in the Workbench package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steward/workbench-audit-adm-zip

Comment @coderabbitai help to get the list of available commands.

@Skiipy11
Skiipy11 merged commit eeedda2 into main Jul 19, 2026
13 checks passed
@Skiipy11
Skiipy11 deleted the steward/workbench-audit-adm-zip branch July 19, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant