Open
Conversation
Contributor
Author
|
@anfragment Review for you |
Member
|
@ilovelinabell Thank you for the PR, and apologies for the delayed response. I'm currently working on a broader rework of the trie to reduce memory usage, and I'd like to revisit this once that's in place. I'm not entirely sure about setting the GC percentage to 5 (it may introduce some CPU overhead if we're not careful with benchmarking), but at the same time, the default value of 100 doesn't feel reasonable for a desktop application either. In any case, please be assured that this PR is still on my radar. |
Member
|
For future reference: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Further improves memory utilization by making the Go garbage collector trigger more frequently. By requiring that the GC trigger each time after Zen allocates a new 5% of memory, we can keep the actual memory used (what Task Manager or Resource Monitor sees) close to the amount of memory Zen actually requires.
How did you verify your code works?
At startup, usage is ~350 to 360 MB. This is about 40-60 MB less than before. The startup time of Zen seems relatively the same, and the browsing/web performance seems unaffected on YT.
What are the relevant issues?
Closes #221