Repository navigation
Server 2.69.1: Tasks view lists numbered and quoted tasks; browser app 2.69.1 - #28
Merged
Merged
Conversation
…d quotes, as the desktop does The server read task lines with its own regex: bullets and `1.` lists only. The desktop's Tasks view reads them with the app's TASK_LINE_RE, which also takes `1)` lists and quoted tasks (`> - [ ]`), and since ZenNotes 2.69.1 the desktop's MCP server and zn (0.7.2) read the same lines. The web app's Tasks view, and anything else that lists tasks through this server, missed those tasks. taskLineRe is now the app's regex; its third group starts at the `]`, which the loop already trimmed, so every other field parses as before. TestParseTasksReadsEveryTaskShape uses the note the desktop's and zn's tests use: the old regex listed 2 of its 5 tasks, this lists all five with their states.
The browser app moves to web-2.69.1-web.he3742063f1986fdb, built from ZenNotes/zennotes 86e98b49 (the v2.69.1 release commit): Convert Table to Database offers the heading right above the table in a long note too. The server's own change is f797ec4: the Tasks view lists tasks in numbered lists and quotes, as the desktop, its MCP server and zn 0.7.2 do. The web client's bridge and routes are unchanged since 2.69.0; no Go dependency moved. Local: prepare-web verified and installed the archive, go vet and go test ./... pass, go test -tags=embed_web ./web passes, and a server built like the release (embed_web) on a scratch vault serves the app (200), answers 401 without the token and lists all five tasks of the shapes note with it.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits. f797ec4: the server's task-line regex is the app's TASK_LINE_RE, so the web app's Tasks view lists tasks in numbered lists (1. and 1)) and quotes (> - [ ]), as the desktop, its MCP server (2.69.1) and zn (0.7.2) do; TestParseTasksReadsEveryTaskShape fails on the old regex (2 of 5 tasks). Then the release commit pins web-2.69.1-web.he3742063f1986fdb (built from the v2.69.1 tag, 86e98b49) and sets release.json to 2.69.1.
Local: prepare-web, go vet, go test ./..., go test -tags=embed_web ./web, and an embed_web build on a scratch vault (app 200, 401 without the token, all five tasks with it).