Repository navigation
Release: pin the 2.68.0 browser artifact and cut server 2.68.0 - #24
Merged
Merged
Conversation
The server writes its own copy of the desktop's demo tour, and desktop 2.68.0 renamed the tour's notes from "00 <long dash> Start Here" to "00 Start Here" (U+2014 read as machine-written everywhere a user saw it) and rewrote the dash out of every note's text. demo-tour.json is regenerated from the desktop's packages/shared-domain/src/demo-tour-data.ts at 2.68.0 (428b8462), which also brings over two notes that had drifted since this copy was last made: Callouts and Footnotes, and the Vim Cheat Sheet. A vault seeded before still holds the old files, so the server now does what the desktop does: regenerating the tour deletes the old-named notes instead of writing a second tour beside them, and removing it deletes them too and reports them. The match is exact on the old separator because both paths delete files; a note named with any other character is someone's own and stays.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server 2.68.0, on the ZenNotes 2.68.0 browser artifact.
web-2.68.0-web.h1c5ca208ca08d773(built from ZenNotes/zennotes881baa6a, the 2.68.0 tag) asweb-artifact/manifest.json;release.json2.68.0.5db21e4):demo-tour.jsonregenerated from the desktop's tour at 2.68.0, whose notes are named "00 Start Here" and so on instead of with a long dash; two notes that had drifted since this copy was made (Callouts and Footnotes, Vim Cheat Sheet) come along. Regenerating the tour now deletes notes under the older names instead of writing a second tour, and removing it deletes them too (an exact match on the old separator, mirroring the desktop'scurrentDemoTourPath). Three new tests; with the cleanup disabled, two of them fail.Local check:
go vet ./internal/...,go test ./internal/...;prepare-webverified the artifact; a-tags=embed_webbuild started isolated (scratch config, vault and port) reportedZenNotes Server: v2.68.0, served/(200), andPOST /api/demo/generatewrote the 17 renamed notes.